Support Quarantined Tests in the Components-E2E Pipeline & Quarantine CanAddAndDisposeRootComponents
#38693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TanayParikh
commented
Nov 29, 2021
dougbu
reviewed
Nov 29, 2021
TanayParikh
commented
Nov 29, 2021
TanayParikh
changed the title
TanayParikh
changed the title
Components-E2E Pipeline & Quarantine CanAddAndDisposeRootComponents
dougbu
approved these changes
Nov 29, 2021
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
If validation build works 
Contributor
Author
|
Hmm still failing E2E (running the quarantined tests in the non-quarantine job). Investigating... |
TanayParikh
added a commit
that referenced
this pull request
Nov 29, 2021
Support for the `QuarantinedTest` attribute. Using the `Quarantined` trait defined here: https://github.com/dotnet/aspnetcore/blob/ba18614ec220c1209a3976f66aacc2c761568931/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs#L18 Extension of #38693 which got auto-merged.
Contributor
Author
|
This got auto-merged. Continuation here: #38704 |
wtgodbe
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Fix `components-e2e` Pipeline Support for the `QuarantinedTest` attribute. Using the `Quarantined` trait defined here: https://github.com/dotnet/aspnetcore/blob/ba18614ec220c1209a3976f66aacc2c761568931/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs#L18 Extension of #38693 which got auto-merged. * Update components-e2e-tests.yml * PR Feedback * Update components-e2e-tests.yml - I pointed to an `xUnit` example, sorry * PR Feedback * PR Feedback * Update artifacts dir Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
10 tasks
TanayParikh
added a commit
that referenced
this pull request
Dec 3, 2021
TanayParikh
added a commit
that referenced
this pull request
Dec 3, 2021
* Fix `components-e2e` Pipeline Support for the `QuarantinedTest` attribute. Using the `Quarantined` trait defined here: https://github.com/dotnet/aspnetcore/blob/ba18614ec220c1209a3976f66aacc2c761568931/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs#L18 Extension of #38693 which got auto-merged. * Update components-e2e-tests.yml * PR Feedback * Update components-e2e-tests.yml - I pointed to an `xUnit` example, sorry * PR Feedback * PR Feedback * Update artifacts dir Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
wtgodbe
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Quarantine CanAddAndDisposeRootComponents (#38693) * Fix `components-e2e` Pipeline (#38704) * Fix `components-e2e` Pipeline Support for the `QuarantinedTest` attribute. Using the `Quarantined` trait defined here: https://github.com/dotnet/aspnetcore/blob/ba18614ec220c1209a3976f66aacc2c761568931/src/Testing/src/xunit/QuarantinedTestTraitDiscoverer.cs#L18 Extension of #38693 which got auto-merged. * Update components-e2e-tests.yml * PR Feedback * Update components-e2e-tests.yml - I pointed to an `xUnit` example, sorry * PR Feedback * PR Feedback * Update artifacts dir Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com> Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Failure Issue: #38613