Skip to content

Remove System.ComponentModel.Annotations Dependency #32447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove System.ComponentModel.Annotations Dependency #32447

wants to merge 5 commits into from

Conversation

TanayParikh
Copy link
Contributor

No description provided.

@TanayParikh
Copy link
Contributor Author

/azp run

TanayParikh
TanayParikh commented May 5, 2021
View reviewed changes
src/Identity/Extensions.Core/src/Microsoft.Extensions.Identity.Core.csproj
@@ -16,7 +16,7 @@
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'">
<Reference Include="System.ComponentModel.Annotations" />
<SuppressBaselineReference Include="System.ComponentModel.Annotations" /> <!-- suppress as a known breaking change -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change introduced.

@TanayParikh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@TanayParikh
Copy link
Contributor Author

This dependency is still going to be required, moving to the non-auto-update section:

src/Identity/Extensions.Core/src/UserValidator.cs(6,29): error CS0234: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'DataAnnotations' does not exist in the namespace 'System.ComponentModel' (are you missing an assembly reference?)

@TanayParikh TanayParikh closed this May 6, 2021
@TanayParikh TanayParikh deleted the taparik/removeComponentModelAnnotations branch May 6, 2021 00:12
This was referenced May 6, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe will be requested when the pull request is marked ready for review wtgodbe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TanayParikh