Skip to content

Downgrade System.ComponentModel.Annotations to 5.0.0 #32484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

Downgrade System.ComponentModel.Annotations to 5.0.0 #32484

merged 1 commit into from
May 7, 2021

Conversation

TanayParikh
Copy link
Contributor

Based on discussion in #32468 due to dead-ending in dotnet/runtime#51891

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 6, 2021
@TanayParikh TanayParikh enabled auto-merge (squash) May 6, 2021 23:14
dougbu
dougbu approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks❕

@TanayParikh TanayParikh merged commit 883476d into main May 7, 2021
@TanayParikh TanayParikh deleted the taparik/dowgradeDataAnnotations branch May 7, 2021 00:36
@ghost ghost added this to the 6.0-preview5 milestone May 7, 2021
@ViktorHofer
Copy link
Member

Why are you even referencing that package? The library is part of the shared framework and I only see it being used in a .NETCoreApp TFM.

@ghost
Copy link

ghost commented May 10, 2021

Hi @ViktorHofer. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@TanayParikh
Copy link
Contributor Author

TanayParikh commented May 10, 2021 •
edited
Loading

Why are you even referencing that package? The library is part of the shared framework and I only see it being used in a .NETCoreApp TFM.

I'd initially tried removing the dependency (#32447) however, it seems the src/Identity/Extensions.Core/src/Microsoft.Extensions.Identity.Core.csproj project relies on it.

@ViktorHofer
Copy link
Member

Ah didn't see that one. Thanks

@ghost
Copy link

ghost commented May 10, 2021

Hi @ViktorHofer. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@lukas-lansky lukas-lansky mentioned this pull request May 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@ericstj ericstj ericstj approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging this pull request may close these issues.
4 participants
@TanayParikh @ViktorHofer @dougbu @ericstj