Emit unhandled exception info via a single console.error call. Fixes #20280 #20907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
added
area-blazor
SteveSandersonMS
requested review from
a team,
captainsafia,
javiercn and
pranavkm
pranavkm
approved these changes
Apr 16, 2020
| // runtime will do if it encounters a truly severe error outside the Blazor | ||
| // code paths. | ||
| Console.Error.WriteLine(formattedMessage); | ||
| _jsRuntime.InvokeVoid("Blazor._internal.dotNetCriticalError", formattedMessage); |
Member
Author
There was a problem hiding this comment.
OK, that's a good idea. Most times it will make no difference, but I guess if the exception is something like "S.T.J. is somehow completely broken" then we don't want to rely on S.T.J. during the reporting of that error.
Done.
javiercn
approved these changes
Apr 16, 2020
captainsafia
approved these changes
Apr 16, 2020
Member
|
Changed around the base branches so that the build on this can re-kick. I'll monitor this build. |
Member
Author
|
Thanks @captainsafia! I've noticed a bug in the new E2E test in |
SteveSandersonMS
force-pushed
the
stevesa/cdn
branch
from
219332a to
52afc53
Compare
SteveSandersonMS
force-pushed
the
stevesa/error-grouping
branch
from
f1039f5 to
a869ad4
Compare
Member
|
Merging this into the other branch now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used
Console.Error.WriteLine. However this is implemented as the stderr stream, which has no message framing, so the recipient has no way to know how successive lines correspond to the originalConsole.Error.WriteLinecalls. So there's no way of putting the lines into groups, hence they each are treated as separateconsole.errorcalls, hence each line emits its own separate stack trace, leading to #20280.The fix is to have a separate dedicated channel for unhandled exception info.