Skip to content

HttpMethodAttribute: fix documentation and parameter check #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2019
Merged

HttpMethodAttribute: fix documentation and parameter check #11133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/Mvc/Mvc.Core/src/Routing/HttpMethodAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,19 @@ public abstract class HttpMethodAttribute : Attribute, IActionHttpMethodProvider
/// <summary>
/// Creates a new <see cref="HttpMethodAttribute"/> with the given
/// set of HTTP methods.
/// <param name="httpMethods">The set of supported HTTP methods.</param>
/// <param name="httpMethods">The set of supported HTTP methods. May not be null.</param>
/// </summary>
public HttpMethodAttribute(IEnumerable<string> httpMethods)
: this(httpMethods, null)
{
if (httpMethods == null)
{
throw new ArgumentNullException(nameof(httpMethods));
}
}

/// <summary>
/// Creates a new <see cref="HttpMethodAttribute"/> with the given
/// set of HTTP methods an the given route template.
/// </summary>
/// <param name="httpMethods">The set of supported methods.</param>
/// <param name="template">The route template. May not be null.</param>
/// <param name="httpMethods">The set of supported methods. May not be null.</param>
/// <param name="template">The route template.</param>
public HttpMethodAttribute(IEnumerable<string> httpMethods, string template)
{
if (httpMethods == null)
Expand Down Expand Up @@ -69,4 +65,4 @@ public int Order
/// <inheritdoc />
public string Name { get; set; }
}
}
}