HttpMethodAttribute: fix documentation and parameter check #11133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second constructor of the `HttpMethodAttribute` class claims that the `template` parameter may not be `null`, and no such claim is present about the `httpMethods` parameter. However, when `httpMethods` is `null`, an exception is thrown, while `template` *is* allowed to be null (as can be seen in the `HttpMethodAttribute(IEnumerable<string>)` constructor, which passes `null`. In addition, the `HttpMethodAttribute(IEnumerable<string>)` constructor contains a `null`-check for the `httpMethods` parameter, but since this check is *also* in the `HttpMethodAttribute(IEnumerable<string>, string)` constructor this check is dead code.
analogrelay
added
the
area-mvc
pranavkm
approved these changes
Jun 12, 2019
|
Thanks for the PR. |
|
My pleasure :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second constructor of the
HttpMethodAttributeclass claims that thetemplateparameter may not benull, and no such claim is present about thehttpMethodsparameter. However, whenhttpMethodsisnull, an exception is thrown, whiletemplateis allowed to be null (as can be seen in theHttpMethodAttribute(IEnumerable<string>)constructor, which passesnull.In addition, the
HttpMethodAttribute(IEnumerable<string>)constructor contains anull-check for thehttpMethodsparameter, but since this check is also in theHttpMethodAttribute(IEnumerable<string>, string)constructor this check is dead code.