Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package Icon Url #544

Closed
wants to merge 1 commit into from
Closed

Update Package Icon Url #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update nuget.props
  • Loading branch information
@Varorbc
Varorbc authored Sep 11, 2019
commit 16ce5ec0297dda0ddcc49beb776a62a2c099a6a2
4 changes: 2 additions & 2 deletions build/nuget.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<PropertyGroup Label="NuGet">
<RepositoryType>git</RepositoryType>
<RepositoryUrl>https://github.com/Microsoft/aspnet-api-versioning</RepositoryUrl>
<PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288890</PackageIconUrl>
<PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</PackageIconUrl>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why, but with NU5048 the PackageIconUrl attribute becomes deprecated and the solution can be an embedded icon, referenced with the PackageIcon or Icon attribute. In my opinion the PackageIconUrl is a handy option for dependent projects like this, but I would go with this rule. May there is a workaround or compromise?

<PackageProjectUrl>https://github.com/Microsoft/aspnet-api-versioning/wiki</PackageProjectUrl>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
Expand Down Expand Up @@ -33,4 +33,4 @@
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta-63127-02" PrivateAssets="All"/>
</ItemGroup>

</Project>
</Project>