Update Package Icon Url #544
Conversation
|
I need to follow up on this for compliance. That is the icon for the .NET Foundation, which this project is not a part of - yet. Many of the large product teams are now part of the .NET Foundation, but since I'm running this myself, I haven't gone through all the steps to make that happen. There are compliance people on NuGet that periodically check for this type of stuff. Changing the icon isn't a huge deal, but it can't be misrepresentation. Naturally, if this project becomes part of the .NET Foundation, the icon will be expected to change. |
| @@ -4,7 +4,7 @@ | |||
| <PropertyGroup Label="NuGet"> | |||
| <RepositoryType>git</RepositoryType> | |||
| <RepositoryUrl>https://github.com/Microsoft/aspnet-api-versioning</RepositoryUrl> | |||
| <PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288890</PackageIconUrl> | |||
| <PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</PackageIconUrl> | |||
There was a problem hiding this comment.
I am not sure why, but with NU5048 the PackageIconUrl attribute becomes deprecated and the solution can be an embedded icon, referenced with the PackageIcon or Icon attribute. In my opinion the PackageIconUrl is a handy option for dependent projects like this, but I would go with this rule. May there is a workaround or compromise?
|
Yeah, I've noticed that warning just started popping up too. I've updated the <PackageIconUrl> as you've done here, but also added the necessary files and support for the new <PackageIcon> format. I'm going to keep both for now as it seems some tools don't use or honor the new in-package icon - yet. I've included the changes in the official 4.0 release that was just merged. I'm going to close this PR as it's no longer necessary, but I referenced it in my changes. Thanks. |
It is recommended to use the .net icon instead of the Microsoft icon