Skip to content

Update hardcoded name in playwright test #8680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 1 commit into from
Apr 9, 2025
Merged

Update hardcoded name in playwright test #8680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using Aspire.TestUtilities;
using Aspire.Dashboard.Configuration;
using Aspire.Dashboard.Resources;
using Aspire.Dashboard.Tests.Integration.Playwright.Infrastructure;
using Aspire.Hosting;
using Microsoft.AspNetCore.InternalTesting;
Expand Down Expand Up @@ -55,7 +56,7 @@ await Assertions
});
}

[Fact(Skip = "https://github.com/dotnet/aspire/issues/7522")]
[Fact]
public async Task BrowserToken_LoginPage_Failure_DisplayFailureMessage()
{
// Arrange
Expand All @@ -77,7 +78,7 @@ await RunTestAsync(async page =>
const int pageVisibleTimeout = 10000;

await Assertions
.Expect(page.GetByText("Invalid token"))
.Expect(page.GetByText(Login.InvalidTokenErrorMessage))
.ToBeVisibleAsync()
.DefaultTimeout(pageVisibleTimeout);
});
Expand Down