Skip to content

Conversation

@adamint
Copy link
Member

@adamint adamint commented Apr 9, 2025

Description

"Invalid token" was the only hardcoded string in GetByText in this class will cause a timeout error on non-EN cultures. Is something about the GH runner culture messed up? I know we had format tests fail before...

Seems to fix #7522

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings April 9, 2025 20:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs:59

  • The test is no longer skipped. Please confirm that this change is intentional and that the test is stable in your CI environment.
[Fact]

tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs:81

  • Ensure that Login.InvalidTokenErrorMessage is defined in Aspire.Dashboard.Resources and returns the expected localized error message.
.Expect(page.GetByText(Login.InvalidTokenErrorMessage))

@adamint adamint requested review from JamesNK and radical April 9, 2025 20:24
@adamint adamint marked this pull request as draft April 9, 2025 20:33
@adamint adamint marked this pull request as ready for review April 9, 2025 20:33
@adamint
Copy link
Member Author

adamint commented Apr 9, 2025

Failing test is unrelated.

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing tests

@danmoseley danmoseley merged commit 555fd34 into dotnet:main Apr 9, 2025
175 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky test: Aspire.Dashboard.Tests.Integration.Playwright.BrowserTokenAuthenticationTests.BrowserToken_LoginPage_Failure_DisplayFailureMessage [FAIL]

3 participants