Reject spans that create a circular loop#6262
Merged
Conversation
mitchdenny
reviewed
Oct 15, 2024
drewnoakes
reviewed
Oct 16, 2024
6556856 to
63583de
Compare
Member
Author
|
I think the changes are too broad to add to 9.0. Can be merged for vnext. |
63583de to
dd1ec4d
Compare
Member
Author
|
PR feedback addressed. |
drewnoakes
approved these changes
Oct 21, 2024
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spans have a parent. A span is not allowed reference itself or one of its anscetors as a parent.
Data sent to the dashboard could contain an invalid circular reference. Rendering the bad data in the UI could cause errors. This PR adds validation logic when spans are received to reject the bad data.
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow