Clean up

Author: JamesNK

src/Aspire.Dashboard/Otlp/Model/SpanCollection.cs renamed to src/Aspire.Dashboard/Otlp/Model/OtlpSpanCollection.cs

@@ -1,16 +1,16 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.ObjectModel;
 
 namespace Aspire.Dashboard.Otlp.Model;
 
-public sealed class SpanCollection : KeyedCollection<string, OtlpSpan>
+public sealed class OtlpSpanCollection : KeyedCollection<string, OtlpSpan>
 {
     // Chosen to balance memory usage overhead of dictionary vs work to find spans by ID.
     private const int DictionaryCreationThreshold = 128;
 
-    public SpanCollection() : base(StringComparers.OtlpSpanId, DictionaryCreationThreshold)
+    public OtlpSpanCollection() : base(StringComparers.OtlpSpanId, DictionaryCreationThreshold)
     {
     }
 
@@ -21,6 +21,7 @@ protected override string GetKeyForItem(OtlpSpan item)
 
     public new List<OtlpSpan>.Enumerator GetEnumerator()
     {
+        // Avoid allocating an enumerator when iterated with foreach.
         return ((List<OtlpSpan>)this.Items).GetEnumerator();
     }
 }

src/Aspire.Dashboard/Otlp/Model/OtlpTrace.cs

@@ -34,7 +34,7 @@ public TimeSpan Duration
         }
     }
 
-    public SpanCollection Spans { get; } = new SpanCollection();
+    public OtlpSpanCollection Spans { get; } = new OtlpSpanCollection();
 
     public int CalculateDepth(OtlpSpan span)
     {
@@ -115,7 +115,7 @@ private static bool HasCircularReference(OtlpSpan span)
         }
 
         // Walk up span ancestors to check there is no loop.
-        var stack = new SpanCollection { span };
+        var stack = new OtlpSpanCollection { span };
         var currentSpan = span;
         while (currentSpan.GetParentSpan() is { } parentSpan)
         {