Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browser token login link when running in a container #5968

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 27, 2024

Description

PR changes:

Builds on top of #5941. Should be merged after that PR.

  • Replace any IP host with localhost in browser token login link that is written to logs.
  • Detect when the dashboard is running in a container and mention that the URL might need to be changed depending on container network configuration.

Fixes #5940

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

Base automatically changed from jamesnk/listenanyip to main September 30, 2024 03:34
@JamesNK JamesNK force-pushed the jamesnk/improve-container-login branch from 1610736 to 8fe3fd2 Compare September 30, 2024 03:35
@JamesNK JamesNK enabled auto-merge (squash) September 30, 2024 03:36
@JamesNK JamesNK merged commit 387f8d2 into main Sep 30, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/improve-container-login branch September 30, 2024 04:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login to the dashboard URL doesn't work when run inside a container
2 participants