Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dashboard listening on any IP #5941

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 26, 2024

Description

While looking at #5940, I noticed that Aspire dashboard docker container used http://0:0:0:0:8080 at its binding in the dockerfile instead of http://+:8080 like all other containers are configured.

The reason is the dashboard doesn't support ASP.NET Core's "any IP" syntax. Fixed in this PR.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK
Copy link
Member Author

JamesNK commented Sep 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit 35cd89b into main Sep 30, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/listenanyip branch September 30, 2024 03:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants