Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package tags for "integration" and "library" terms #5403

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Update package tags for "integration" and "library" terms #5403

merged 4 commits into from
Aug 23, 2024

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Aug 23, 2024 •
edited
Loading

Updates the package tags to use the "integration" term. The previously termed "component" packages have "library" added also, so we have "integration hosting" packages and "integration library" packages. The "component" tag isn't being removed as yet as the Visual Studio "Add Aspire package" experience still relies on it.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 23, 2024
@build-analysis build-analysis bot mentioned this pull request Aug 23, 2024
Open
3 tasks
eerhardt
eerhardt approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DamianEdwards DamianEdwards enabled auto-merge (squash) August 23, 2024 21:22
@eerhardt
Copy link
Member

/backport to release/8.2

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10532561374

@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Merged
@DamianEdwards
Copy link
Member Author

Failure looks like a Helix job timeout. Is this common @radical?

@radical
Copy link
Member

radical commented Aug 23, 2024

Failure looks like a Helix job timeout. Is this common @radical?

Only the Cosmos failure in Aspire.Playground.Tests is known to fail sometimes.

The other two:

  1. Mysql - times out waiting for s_mySqlReadyText = log => log.Contains("ready for connections") && log.Contains("port: 3306");.

  2. RabbitMQ is timing out after 1 minute because the docker image was being pulled before the container could be started.

For a separate PR: We should add WaitForResources in general before WaitForTextAsync in the tests.

@radical
Copy link
Member

radical commented Aug 23, 2024

We should add WaitForResources in general before WaitForTextAsync in the tests.

Opened #5414

@DamianEdwards DamianEdwards merged commit 03d22f5 into main Aug 23, 2024
11 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards/package-tags-update branch August 23, 2024 23:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IEvangelist IEvangelist IEvangelist left review comments

@eerhardt eerhardt eerhardt approved these changes

@jamesmontemagno jamesmontemagno jamesmontemagno approved these changes

@radical radical Awaiting requested review from radical radical is a code owner

@sebastienros sebastienros Awaiting requested review from sebastienros sebastienros is a code owner

@joperezr joperezr Awaiting requested review from joperezr

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DamianEdwards @eerhardt @radical @jamesmontemagno @IEvangelist