-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding public API test coverage for Aspire.Hosting.MongoDB #5201
Merged
sebastienros
merged 6 commits into
dotnet:main
from
Alirexaa:validate-arguments-of-public-methods#aspire-hosting-mongodb
Aug 14, 2024
Merged
Adding public API test coverage for Aspire.Hosting.MongoDB #5201
sebastienros
merged 6 commits into
dotnet:main
from
Alirexaa:validate-arguments-of-public-methods#aspire-hosting-mongodb
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
label
Aug 6, 2024
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Aug 6, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
radical
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the few comments, LGTM.
3 tasks
56 tasks
Co-authored-by: Ankit Jain <radical@gmail.com>
sebastienros
approved these changes
Aug 9, 2024
…aspire-hosting-mongodb
…aspire-hosting-mongodb
Alirexaa
deleted the
validate-arguments-of-public-methods#aspire-hosting-mongodb
branch
August 14, 2024 07:32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2649 and #5047
Microsoft Reviewers: Open in CodeFlow