Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding public API test coverage for Aspire.Hosting.MongoDB #5201

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Aug 6, 2024

Contributes to #2649 and #5047

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Aug 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 6, 2024
@mitchdenny
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the few comments, LGTM.

src/Aspire.Hosting.MongoDB/MongoDBDatabaseResource.cs Outdated Show resolved Hide resolved
src/Aspire.Hosting.MongoDB/MongoDBDatabaseResource.cs Outdated Show resolved Hide resolved
Alirexaa and others added 2 commits August 7, 2024 11:38
Co-authored-by: Ankit Jain <radical@gmail.com>
@sebastienros sebastienros enabled auto-merge (squash) August 9, 2024 17:45
@sebastienros sebastienros merged commit 6b295c5 into dotnet:main Aug 14, 2024
11 checks passed
@Alirexaa Alirexaa deleted the validate-arguments-of-public-methods#aspire-hosting-mongodb branch August 14, 2024 07:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants