-
Notifications
You must be signed in to change notification settings - Fork 705
Closed
Labels
area-app-modelIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplicationIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplicationgood first issueGood for newcomersGood for newcomershelp wantedIssue that is a good candidate for community contribution.Issue that is a good candidate for community contribution.
Description
I noticed we seem to have lots of public APIs that accept reference type parameters not marked as nullable but then don't check that they're actually non-null and throw an ArgumentNullException when necessary. We should decide what we're doing and review all public APIs for appropriate argument validation.
e.g.
aspire/src/Aspire.Hosting/Extensions/ResourceBuilderExtensions.cs
Lines 92 to 98 in 240cde7
| public static IResourceBuilder<T> WithEnvironment<T>(this IResourceBuilder<T> builder, string name, IResourceBuilder<ParameterResource> parameter) where T : IResourceWithEnvironment | |
| { | |
| return builder.WithEnvironment(context => | |
| { | |
| context.EnvironmentVariables[name] = parameter.Resource; | |
| }); | |
| } |
Metadata
Metadata
Assignees
Labels
area-app-modelIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplicationIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplicationgood first issueGood for newcomersGood for newcomershelp wantedIssue that is a good candidate for community contribution.Issue that is a good candidate for community contribution.