Skip to content

[release/8.0-preview5] Retry on YamlException when loading Kubernetes client configuration #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[release/8.0-preview5] Retry on YamlException when loading Kubernetes client configuration #3231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3723bc0
Retry on YamlException when loading Kubernetes client configuration
ReubenBond Mar 27, 2024
0061675
Add comment
ReubenBond Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Aspire.Hosting/Dcp/KubernetesService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using Microsoft.Extensions.Options;
using Polly;
using Polly.Retry;
using YamlDotNet.Core;

namespace Aspire.Hosting.Dcp;

Expand Down Expand Up @@ -296,7 +297,9 @@ private ResiliencePipeline GetReadKubeconfigResiliencePipeline()
{
var configurationReadRetry = new RetryStrategyOptions()
{
ShouldHandle = new PredicateBuilder().Handle<KubeConfigException>(),
// Handle exceptions caused by races between writing and reading the configuration file.
// If the file is loaded while it is still being written, this can result in a YamlException being thrown.
ShouldHandle = new PredicateBuilder().Handle<KubeConfigException>().Handle<YamlException>(),
BackoffType = DelayBackoffType.Constant,
MaxRetryAttempts = dcpOptions.Value.KubernetesConfigReadRetryCount,
MaxDelay = TimeSpan.FromMilliseconds(dcpOptions.Value.KubernetesConfigReadRetryIntervalMilliseconds),
Expand Down