[release/8.0-preview5] Retry on YamlException when loading Kubernetes client configuration #3231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-app-model
davidfowl
approved these changes
Mar 27, 2024
ReubenBond
approved these changes
Mar 27, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3229 to release/8.0-preview5
/cc @davidfowl @ReubenBond
Customer Impact
This improves reliability during startup and mitigates an existing race condition.
Testing
Manual.
Risk
Low. If there are legitimate YAML parsing exceptions, this could cause the file to be retried regardless, fruitlessly, but retries are capped by the policy, so this very rare case will not result in an infinite loop.
Microsoft Reviewers: Open in CodeFlow