archives.targets: Fix creating tar.gz on Windows #15913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating .tar.gz arhives on windows from `_CreateArchive` target fails silently with: `tar: could not chdir to ''C:\Users\ankj\source\repos\aspire\artifacts\obj\Aspire.Cli.linux-arm64\Debug\net8.0\output/''` Fixing the mismatched directory separators does not help, neither does removing the trailing `/'`. Instead this whole thing can be side-stepped by using `WorkingDirectory` parameter of the `Exec` task. Also: - fixes the path used in generation of the symbols tarball - Construct the various paths using msbuild's `NormalizePath`, and `NormalizeDirectory` functions so they get the correct directory separators.
Member
Author
danmoseley
approved these changes
Jun 19, 2025
ViktorHofer
approved these changes
Jun 23, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
radical
added a commit
to radical/arcade
that referenced
this pull request
Jun 24, 2025
Backport dotnet#15913 ``` commit debf971 Author: Ankit Jain <radical@gmail.com> Date: Mon Jun 23 13:08:03 2025 -0400 archives.targets: Fix creating tar.gz on Windows (dotnet#15913) ```
1 task
akoeplinger
reviewed
Jun 24, 2025
| <Exec Command="tar -cf - . | pigz > '$(_DestinationFileName)'" | ||
| IgnoreExitCode="true" | ||
| IgnoreStandardErrorWarningFormat="true" | ||
| WorkingDirectory="$(_SymbolsOutputPathRoot)" |
Member
There was a problem hiding this comment.
this actually fixed a wrong change from 101a54b which used $(_OutputPathRoot) instead of $(_SymbolsOutputPathRoot) here.
I'm a bit surprised we haven't seen any breakages due to this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating .tar.gz arhives on windows from
_CreateArchivetargetfails silently with:
tar: could not chdir to ''C:\Users\ankj\source\repos\aspire\artifacts\obj\Aspire.Cli.linux-arm64\Debug\net8.0\output/''Fixing the mismatched directory separators does not help, neither does
removing the trailing
/'. Instead this whole thing can be side-steppedby using
WorkingDirectoryparameter of theExectask.Also:
NormalizePath, andNormalizeDirectoryfunctions so they get the correct directoryseparators.
cc @joperezr @danmoseley