Build logs are no longer gathered and published on error

[elinor-fung]

When a build that is set to publish logs (for example, via setting artifacts.publish.logs) errors out, no logs are published. Successful builds do publish their logs.

@chcosta I think this is from #14736

Example build failure without logs published: https://dev.azure.com/dnceng-public/public/_build/results?buildId=685790&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=d2b92d58-337d-5541-2ecb-d35f35f29352
'Gather logs for publish to artifacts' is skipped and then `Publish logs' can't actually publish anything, since logs weren't copied to the expected location..

The task for gathering logs to publish that isn't run:

arcade/eng/common/core-templates/job/job.yml

Lines 242 to 256 in de91541

	- ${{ if and(ne(parameters.artifacts.publish.logs, 'false'), ne(parameters.artifacts.publish.logs, '')) }}:
	- task: CopyFiles@2
	displayName: Gather logs for publish to artifacts
	inputs:
	SourceFolder: 'artifacts/log'
	Contents: '**'
	TargetFolder: '$(Build.ArtifactStagingDirectory)/artifacts/log'
	- ${{ if eq(parameters.enablePublishBuildArtifacts, 'true') }}:
	- task: CopyFiles@2
	displayName: Gather logs for publish to artifacts
	inputs:
	SourceFolder: 'artifacts/log/$(_BuildConfig)'
	Contents: '**'
	TargetFolder: '$(Build.ArtifactStagingDirectory)/artifacts/log/$(_BuildConfig)'

I think they just need continueOnError: true. But perhaps other places should also have that (maybe gathering binaries/packages?).

Before the template refactor:

arcade/eng/common/templates/job/job.yml

Lines 208 to 213 in 857f51e

	- ${{ if and(ne(parameters.artifacts.publish.logs, 'false'), ne(parameters.artifacts.publish.logs, '')) }}:
	- publish: artifacts/log
	artifact: ${{ coalesce(parameters.artifacts.publish.logs.name, 'Logs_Build_$(Agent.Os)_$(_BuildConfig)') }}
	displayName: Publish logs
	continueOnError: true
	condition: always()

[chcosta]

Ack, I'll take a look tomorrow

[chcosta]

I'm validating a fix for this