[msbuild] remove --dex argument and add DxExtraArguments from Dx task. #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise debugging won't work with d8/r8.
|
Where do we set the default for |
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
dotnet#990) Otherwise debugging won't work with d8/r8.
jonpryor
pushed a commit
that referenced
this pull request
Jun 14, 2022
Changes: dotnet/java-interop@d0ef9e3...51c3dae * dotnet/java-interop@51c3dae7: [Java.Interop-MonoAndroid.csproj] Add jnienv-gen ProjectReference (#990) Remove all instances of `dotnet build -m:1` from the build system, and fix all issues which prevent it from appearing to work. (Testing was via 4 consecutive CI builds without errors. This does not mean it's a complete fix, but it seems good enough to merge.) Fixes include: Using `build-tools/create-android-api` (9987069) to build `JNIEnv.g.cs` only once, instead of once per `$(TargetFrameworkVersion)`. This prevents sharing violations when multiple `Mono.Android.csproj` builds attempt to create it simultaneously: System.IO.IOException: The process cannot access the file 'C:\a\_work\1\s\src\Mono.Android\Android.Runtime\JNIEnv.g.cs' because it is being used by another process. *Serialize* gradlew-using project references, such that `r8.csproj` has a `@(ProjectReference)` to `manifestmerger.csproj`, and `manifestmerger.csproj` has a `@(ProjectReference)` to `apksigner.csproj`. `gradlew` execution can time out when multiple `gradlew` instances are run concurrently, even if `gradlew --no-daemon` is used. Serializing these project references avoids the errors: org.gradle.launcher.daemon.client.DaemonConnectionException: Timeout waiting to connect to the Gradle daemon. The file lock is held by a different Gradle process. Add a `@(ProjectReference)` on `Microsoft.Android.Sdk.ILLink.csproj` to `Xamarin.Android.Build.Tasks.csproj`, so that `Xamarin.Android.Build.Tasks\obj\$(Configuration)\Profile.g.cs` is available for compilation. Fixes: CSC error CS2001: Source file 'C:\code\xamarin-android\src\Microsoft.Android.Sdk.ILLink\..\Xamarin.Android.Build.Tasks\obj\Debug\Profile.g.cs' could not be found. Commit dotnet/java-interop@51c3dae7, which adds a `@(ProjectReference)` on `Java.Interop-MonoAndroid.csproj` to `jnienv-gen.csproj`, which ensures that `jnienv-gen.exe` exists when `Java.Interop-MonoAndroid.csproj` is built. Fix errors such as: '"C:\a\_work\1\s\external\Java.Interop\bin\BuildRelease\jnienv-gen.exe"' is not recognized as an internal or external command, operable program or batch file. or …/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop.targets(19,5): error MSB3073: The command "mono "…/xamarin-android/external/Java.Interop/bin/BuildDebug/jnienv-gen.exe" Java.Interop/JniEnvironment.g.cs obj/Debug/jni.c" exited with code 2. […/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop-MonoAndroid.csproj]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise debugging won't work with d8/r8.