[build] Fix issues preventing parallel builds (#7068)

Changes: dotnet/java-interop@d0ef9e3...51c3dae

  * dotnet/java-interop@51c3dae7: [Java.Interop-MonoAndroid.csproj] Add jnienv-gen ProjectReference (#990)

Remove all instances of `dotnet build -m:1` from the build system,
and fix all issues which prevent it from appearing to work.

(Testing was via 4 consecutive CI builds without errors.  This does
not mean it's a complete fix, but it seems good enough to merge.)

Fixes include:

Using `build-tools/create-android-api` (9987069) to build
`JNIEnv.g.cs` only once, instead of once per
`$(TargetFrameworkVersion)`.  This prevents sharing violations when
multiple `Mono.Android.csproj` builds attempt to create it
simultaneously:

	System.IO.IOException: The process cannot access the file 'C:\a\_work\1\s\src\Mono.Android\Android.Runtime\JNIEnv.g.cs' because it is being used by another process.

*Serialize* gradlew-using project references, such that `r8.csproj`
has a `@(ProjectReference)` to `manifestmerger.csproj`, and
`manifestmerger.csproj` has a `@(ProjectReference)` to
`apksigner.csproj`.  `gradlew` execution can time out when multiple
`gradlew` instances are run concurrently, even if
`gradlew  --no-daemon` is used.  Serializing these project references
avoids the errors:

	org.gradle.launcher.daemon.client.DaemonConnectionException: Timeout waiting to connect to the Gradle daemon.
	The file lock is held by a different Gradle process.

Add a `@(ProjectReference)` on `Microsoft.Android.Sdk.ILLink.csproj` to
`Xamarin.Android.Build.Tasks.csproj`, so that
`Xamarin.Android.Build.Tasks\obj\$(Configuration)\Profile.g.cs` is
available for compilation.  Fixes:

	CSC error CS2001: Source file 'C:\code\xamarin-android\src\Microsoft.Android.Sdk.ILLink\..\Xamarin.Android.Build.Tasks\obj\Debug\Profile.g.cs' could not be found.

Commit dotnet/java-interop@51c3dae7, which adds a
`@(ProjectReference)` on `Java.Interop-MonoAndroid.csproj` to
`jnienv-gen.csproj`, which ensures that `jnienv-gen.exe` exists when
`Java.Interop-MonoAndroid.csproj` is built.  Fix errors such as:

	'"C:\a\_work\1\s\external\Java.Interop\bin\BuildRelease\jnienv-gen.exe"' is not recognized as an internal or external command, operable program or batch file.

or

	…/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop.targets(19,5):
	error MSB3073: The command "mono "…/xamarin-android/external/Java.Interop/bin/BuildDebug/jnienv-gen.exe" Java.Interop/JniEnvironment.g.cs obj/Debug/jni.c" exited with code 2.
	[…/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop-MonoAndroid.csproj]

Author: jpobst

Directory.Build.props

@@ -21,6 +21,8 @@
     <ProduceReferenceAssemblyInOutDir>true</ProduceReferenceAssemblyInOutDir>
     <!-- Ensure command-line apps can use a newer .NET -->
     <RollForward>Major</RollForward>
+    <!-- We don't need to be warned that we are using a preview .NET -->
+    <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(MSBuildRuntimeType)' == 'Core' ">

build-tools/automation/azure-pipelines.yaml

@@ -208,7 +208,7 @@ stages:
       parameters:
         project: Xamarin.Android.sln
         arguments: >-
-          -t:BuildDotNet,PackDotNet -c $(XA.Build.Configuration) -m:1 -v:n
+          -t:BuildDotNet,PackDotNet -c $(XA.Build.Configuration) -v:n
           -bl:$(System.DefaultWorkingDirectory)\bin\Build$(XA.Build.Configuration)\dotnet-build.binlog
         displayName: Build Solution
         continueOnError: false

build-tools/create-android-api/create-android-api.csproj

@@ -12,6 +12,7 @@
     <ProjectReference Include="..\..\external\Java.Interop\tools\class-parse\class-parse.csproj" ReferenceOutputAssembly="False" />
     <ProjectReference Include="..\api-xml-adjuster\api-xml-adjuster.csproj" ReferenceOutputAssembly="False" />
     <ProjectReference Include="..\api-merge\api-merge.csproj" ReferenceOutputAssembly="False" />
+    <ProjectReference Include="..\jnienv-gen\jnienv-gen.csproj" ReferenceOutputAssembly="False" SkipGetTargetFrameworkProperties="True" AdditionalProperties="TargetFramework=net472" />
   </ItemGroup>
 
   <PropertyGroup>
@@ -117,6 +118,17 @@
         Command="$(ManagedRuntime) $(ManagedRuntimeArgs) $(ApiMerge) -config=$(_ConfigurationFile) -config-input-dir=$(_ConfigurationInputBaseDirectory) -config-output-dir=$(_ConfigurationOutputBaseDirectory)" />
 
   </Target>
+  
+  <!-- Generates 'JNIEnv.g.cs' file. We do this here because it should only run once, not per-TF.  -->
+  <Target Name="_BuildJNIEnv"
+      BeforeTargets="Build"
+      Inputs="..\..\bin\Build$(Configuration)\jnienv-gen.exe"
+      Outputs="../../src/Mono.Android/Android.Runtime/JNIEnv.g.cs">
+    <Exec
+        Command="$(ManagedRuntime) $(ManagedRuntimeArgs) &quot;../../bin/Build$(Configuration)/jnienv-gen.exe&quot; -o ../../src/Mono.Android/Android.Runtime/JNIEnv.g.cs --use-java-interop"
+    />
+    <Touch Files="../../src/Mono.Android/Android.Runtime/JNIEnv.g.cs" />
+  </Target>
 
   <!-- Clean up generated API files -->
   <Target Name="_CleanApiXml"

build-tools/scripts/BuildEverything.mk

@@ -27,6 +27,6 @@ endif
 leeroy: leeroy-all framework-assemblies
 
 leeroy-all:
-	$(call DOTNET_BINLOG,leeroy-all) $(SOLUTION) -m:1 $(_MSBUILD_ARGS)
+	$(call DOTNET_BINLOG,leeroy-all) $(SOLUTION) $(_MSBUILD_ARGS)
 	$(call DOTNET_BINLOG,setup-workload) -t:ConfigureLocalWorkload build-tools/create-packs/Microsoft.Android.Sdk.proj
 	$(call MSBUILD_BINLOG,leeroy-all,$(_SLN_BUILD)) /restore tools/xabuild/xabuild.csproj /p:Configuration=$(CONFIGURATION) $(_MSBUILD_ARGS)

external/Java.Interop

@@ -12,6 +12,7 @@
     <PackageReference Include="Microsoft.NET.ILLink" Version="$(MicrosoftNETILLinkTasksPackageVersion)" />
     <PackageReference Include="XliffTasks" Version="$(XliffTasksVersion)" PrivateAssets="all" />
     <ProjectReference Include="..\..\external\Java.Interop\src\Java.Interop.Export\Java.Interop.Export.csproj" />
+    <ProjectReference Include="..\Xamarin.Android.Build.Tasks\Xamarin.Android.Build.Tasks.csproj" ReferenceOutputAssembly="False" />
 
     <Compile Include="..\Xamarin.Android.Build.Tasks\obj\$(Configuration)\Profile.g.cs" Link="Profile.g.cs" />
 

src/Microsoft.Android.Sdk.ILLink/Microsoft.Android.Sdk.ILLink.csproj

@@ -374,7 +374,6 @@
   <ItemGroup>
     <ProjectReference Include="..\..\build-tools\create-android-api\create-android-api.csproj" ReferenceOutputAssembly="false" />
     <!-- Explicitly pass the target framework of the project so we don't have conflicts with the multiple targets in this file. -->
-    <ProjectReference Include="..\..\build-tools\jnienv-gen\jnienv-gen.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472" />
     <ProjectReference Include="..\..\external\Java.Interop\tools\generator\generator.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472"/>
     <ProjectReference Include="..\..\external\Java.Interop\tools\java-source-utils\java-source-utils.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=$(DotNetTargetFramework)" />
     <ProjectReference Include="..\..\external\Java.Interop\tools\jcw-gen\jcw-gen.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" AdditionalProperties="TargetFramework=net472" />

src/Mono.Android/Mono.Android.csproj

@@ -30,11 +30,12 @@
       <_GlobalProperties>
         JavaInteropProfile=Net45;
         XAInstallPrefix=$(XAInstallPrefix);
-        TargetFrameworkIdentifier=MonoAndroid;
-        TargetFrameworkVersion=v1.0;
-        TargetFrameworkRootPath=$(XAInstallPrefix)xbuild-frameworks;
       </_GlobalProperties>
     </PropertyGroup>
+    <MSBuild
+        Projects="$(JavaInteropFullPath)\build-tools\jnienv-gen\jnienv-gen.csproj"
+        Properties="TargetFramework=net472;"
+    />
     <MSBuild
         Projects="$(JavaInteropFullPath)\src\Java.Interop\Java.Interop-MonoAndroid.csproj"
         Properties="$(_GlobalProperties)"
@@ -120,17 +121,6 @@
     <Touch Files="$(_AndroidJavadocXml)" />
   </Target>
 
-  <!-- Generates 'JNIEnv.g.cs' file -->
-  <Target Name="_BuildJNIEnv"
-      BeforeTargets="CoreCompile"
-      Inputs="..\..\bin\Build$(Configuration)\jnienv-gen.exe"
-      Outputs="Android.Runtime\JNIEnv.g.cs">
-    <Exec
-        Command="$(ManagedRuntime) $(ManagedRuntimeArgs) &quot;../../bin/Build$(Configuration)/jnienv-gen.exe&quot; -o Android.Runtime/JNIEnv.g.cs --use-java-interop"
-    />
-    <Touch Files="Android.Runtime\JNIEnv.g.cs" />
-  </Target>
-  
   <!-- Copies common 'api-X.xml' to the 'obj' directory.
        This is needed because 'generator' writes intermediate files like 'api-X.xml.fixed' next to the source
        'api-X.xml' and multiple profiles are using the source, so these files will clobber each other. -->

src/Mono.Android/Mono.Android.targets

@@ -7,6 +7,12 @@
   </PropertyGroup>
 
   <Import Project="..\..\Configuration.props" />
+
+  <ItemGroup>
+    <!-- There isn't an actual dependency here, but we can only build one 'gradlew' project
+         at a time, and adding <ProjectReference> between them ensures they run sequentially. -->
+    <ProjectReference Include="..\apksigner\apksigner.csproj" ReferenceOutputAssembly="False" />
+  </ItemGroup>
 
   <Import Project="manifestmerger.targets" />
 </Project>

src/manifestmerger/manifestmerger.csproj

@@ -8,6 +8,12 @@
     <OutputPath Condition="'$(OutputPath)'==''">bin\$(Configuration)</OutputPath>
   </PropertyGroup>
 
+  <ItemGroup>
+    <!-- There isn't an actual dependency here, but we can only build one 'gradlew' project
+         at a time, and adding <ProjectReference> between them ensures they run sequentially. -->
+    <ProjectReference Include="..\manifestmerger\manifestmerger.csproj" ReferenceOutputAssembly="False" />
+  </ItemGroup>
+
   <Import Project="..\..\Configuration.props" />
   <Import Project="r8.targets" />
 </Project>