[tests] InstallAndroidDependenciesTest can use platform-tools 34.0.1
#7873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: bec42ef Context: 9752257 Context: … Context: https://dl-ssl.google.com/android/repository/repository2-3.xml Whenever Google updates their `repository2-3.xml`, there is a chance that our `AndroidDependenciesTests.InstallAndroidDependenciesTest()` unit test will fail, as `repository2-3.xml` containsn *only one* platform-tools package version, and when that changes, out test breaks. Tracking down the cause of this breakage is annoying, usually because when this happens we've forgotten that platform-tools package version changes are the primary reason `InstallAndroidDependencies()` fails. 😅 Update `AndroidDependenciesTests.InstallAndroidDependenciesTest()` to set `$(AndroidSdkPlatformToolsVersion)`=34.0.1, fixing the test, *and also* update the test so that when the wrong `$(_AndroidSdkDirectory)` value is found, we read the *current version* of the platform-tools package from `repository2-3.xml` and include that information in our assertion message.
jonathanpeppers
approved these changes
Mar 10, 2023
| } | ||
| } | ||
| catch (Exception e) { | ||
| // ignore |
There was a problem hiding this comment.
I would maybe still TestContext.WriteLine(e)?
jonathanpeppers
pushed a commit
that referenced
this pull request
Mar 11, 2023
…#7873) Context: bec42ef Context: 9752257 Context: … Context: https://dl-ssl.google.com/android/repository/repository2-3.xml Whenever Google updates their `repository2-3.xml`, there is a chance that our `AndroidDependenciesTests.InstallAndroidDependenciesTest()` unit test will fail, as `repository2-3.xml` containsn *only one* platform-tools package version, and when that changes, out test breaks. Tracking down the cause of this breakage is annoying, usually because when this happens we've forgotten that platform-tools package version changes are the primary reason `InstallAndroidDependencies()` fails. 😅 Update `AndroidDependenciesTests.InstallAndroidDependenciesTest()` to set `$(AndroidSdkPlatformToolsVersion)`=34.0.1, fixing the test, *and also* update the test so that when the wrong `$(_AndroidSdkDirectory)` value is found, we read the *current version* of the platform-tools package from `repository2-3.xml` and include that information in our assertion message.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 13, 2023
* main: [tests] `InstallAndroidDependenciesTest` uses `platform-tools` 34.0.1 (dotnet#7873) [ci] Parallelize and reduce overhead of MSBuild test stage. (dotnet#7850) [Xamarin.Android.Build.Tasks] Remove MAM targets from CoreResolve (dotnet#7868)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 13, 2023
* main: [tests] `InstallAndroidDependenciesTest` uses `platform-tools` 34.0.1 (dotnet#7873) [ci] Parallelize and reduce overhead of MSBuild test stage. (dotnet#7850) [Xamarin.Android.Build.Tasks] Remove MAM targets from CoreResolve (dotnet#7868)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 13, 2023
* main: [tests] `InstallAndroidDependenciesTest` uses `platform-tools` 34.0.1 (dotnet#7873) [ci] Parallelize and reduce overhead of MSBuild test stage. (dotnet#7850) [Xamarin.Android.Build.Tasks] Remove MAM targets from CoreResolve (dotnet#7868)
jonathanpeppers
pushed a commit
that referenced
this pull request
Mar 20, 2023
…#7873) Context: bec42ef Context: 9752257 Context: … Context: https://dl-ssl.google.com/android/repository/repository2-3.xml Whenever Google updates their `repository2-3.xml`, there is a chance that our `AndroidDependenciesTests.InstallAndroidDependenciesTest()` unit test will fail, as `repository2-3.xml` containsn *only one* platform-tools package version, and when that changes, out test breaks. Tracking down the cause of this breakage is annoying, usually because when this happens we've forgotten that platform-tools package version changes are the primary reason `InstallAndroidDependencies()` fails. 😅 Update `AndroidDependenciesTests.InstallAndroidDependenciesTest()` to set `$(AndroidSdkPlatformToolsVersion)`=34.0.1, fixing the test, *and also* update the test so that when the wrong `$(_AndroidSdkDirectory)` value is found, we read the *current version* of the platform-tools package from `repository2-3.xml` and include that information in our assertion message.
jonpryor
added a commit
that referenced
this pull request
Apr 21, 2023
…#7873) Context: bec42ef Context: 9752257 Context: … Context: https://dl-ssl.google.com/android/repository/repository2-3.xml Whenever Google updates their `repository2-3.xml`, there is a chance that our `AndroidDependenciesTests.InstallAndroidDependenciesTest()` unit test will fail, as `repository2-3.xml` containsn *only one* platform-tools package version, and when that changes, out test breaks. Tracking down the cause of this breakage is annoying, usually because when this happens we've forgotten that platform-tools package version changes are the primary reason `InstallAndroidDependencies()` fails. 😅 Update `AndroidDependenciesTests.InstallAndroidDependenciesTest()` to set `$(AndroidSdkPlatformToolsVersion)`=34.0.1, fixing the test, *and also* update the test so that when the wrong `$(_AndroidSdkDirectory)` value is found, we read the *current version* of the platform-tools package from `repository2-3.xml` and include that information in our assertion message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: bec42ef
Context: 9752257
Context: …
Context: https://dl-ssl.google.com/android/repository/repository2-3.xml
Whenever Google updates their
repository2-3.xml, there is a chance that ourAndroidDependenciesTests.InstallAndroidDependenciesTest()unit test will fail, asrepository2-3.xmlcontainsn only one platform-tools package version, and when that changes, out test breaks.Tracking down the cause of this breakage is annoying, usually because when this happens we've forgotten that platform-tools package version changes are the primary reason
InstallAndroidDependencies()fails. 😅Update
AndroidDependenciesTests.InstallAndroidDependenciesTest()to set$(AndroidSdkPlatformToolsVersion)=34.0.1, fixing the test, and also update the test so that when the wrong$(_AndroidSdkDirectory)value is found, we read the current version of the platform-tools package fromrepository2-3.xmland include that information in our assertion message.