You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context: bec42ef
Context: 9752257
Context: …
Context: https://dl-ssl.google.com/android/repository/repository2-3.xml
Whenever Google updates their `repository2-3.xml`, there is a chance
that our `AndroidDependenciesTests.InstallAndroidDependenciesTest()`
unit test will fail, as `repository2-3.xml` containsn *only one*
platform-tools package version, and when that changes, out test breaks.
Tracking down the cause of this breakage is annoying, usually because
when this happens we've forgotten that platform-tools package version
changes are the primary reason `InstallAndroidDependencies()` fails. 😅
Update `AndroidDependenciesTests.InstallAndroidDependenciesTest()`
to set `$(AndroidSdkPlatformToolsVersion)`=34.0.1, fixing the test,
*and also* update the test so that when the wrong
`$(_AndroidSdkDirectory)` value is found, we read the *current version*
of the platform-tools package from `repository2-3.xml` and include
that information in our assertion message.
}),"InstallAndroidDependencies should have succeeded.");
44
46
b.Target=defaultTarget;
45
47
b.BuildLogFile="build.log";
46
48
Assert.IsTrue(b.Build(proj,true),"build should have succeeded.");
47
-
Assert.IsTrue(b.LastBuildOutput.ContainsText($"Output Property: _AndroidSdkDirectory={sdkPath}"),$"_AndroidSdkDirectory was not set to new SDK path `{sdkPath}`.");
0 commit comments