[Xamarin.Android.Build.Tasks] Add 'android:exported="true"' to Timing.xml #7551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….xml API 33 requires that publicly accessible receivers need to have `android:exported="true"` added to them in order to them to work. The Timing.xml overlay did not have this attribute, so lets add it.
dellis1972
requested review from
grendello
and removed request for
jonathanpeppers
grendello
approved these changes
Nov 10, 2022
jonathanpeppers
approved these changes
Nov 10, 2022
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 14, 2022
* main: [ci] Enable CodeQL on nightly build (dotnet#7522) Bump to xamarin/Java.Interop/main@984711a (dotnet#7545) [Xamarin.Android.Build.Tasks] Timing.xml & `android:exported="true"` (dotnet#7551) [Xamarin.Android.Build.Tasks] run a Clean if the project path changes. (dotnet#7476)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API 33 requires that publicly accessible receivers need to have
android:exported="true"added to them in order to them to work.The Timing.xml overlay did not have this attribute, so lets add it.