-
Notifications
You must be signed in to change notification settings - Fork 552
[ci] Enable CodeQL on nightly build #7522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: build-tools/scripts/DotNet.targets
Nightly test run which enables this is currently running https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6947738&view=logs&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e&t=ae8c6cc7-b771-5f24-4cb4-cca8c9ef6480 |
The nightly run looks like it finally completed successfully (after four hours), I'm going to bump the build job timeout again. |
dellis1972
approved these changes
Nov 11, 2022
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 14, 2022
* main: [ci] Enable CodeQL on nightly build (dotnet#7522) Bump to xamarin/Java.Interop/main@984711a (dotnet#7545) [Xamarin.Android.Build.Tasks] Timing.xml & `android:exported="true"` (dotnet#7551) [Xamarin.Android.Build.Tasks] run a Clean if the project path changes. (dotnet#7476)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/codeql/codeql-semmle
CodeQL static analysis has been added to our nightly build job. This
tool dramatically increases build times, and for complex builds like
xamarin-android it should run in a separate pipeline that is not time
sensitive. CodeQL will only run against commits to the main branch.