[xaprepare] use 8.0.100 version band for Mono workloads #7530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/runtime#77385 Building `net6.0-android` and `net7.0-android` apps with .NET 8 is failing with: Microsoft.Android.Sdk.RuntimeConfig.targets(46,5): error MSB4036: The "RuntimeConfigParserTask" task was not found. Check the following: 1.) The name of the task in the project file is the same as the name of the task class. 2.) The task class is "public" and implements the Microsoft.Build.Framework.ITask interface. 3.) The task is correctly declared with <UsingTask> in the project file, or in the *.tasks files located in the "/Users/runner/work/1/s/xamarin-android/bin/Release/dotnet/sdk/8.0.100-alpha.1.22553.2" directory. The problem appears to be due to the import ordering: 8.0.100-alpha.1/microsoft.net.workload.mono.toolchain.net6/WorkloadManifest.targets 8.0.100-alpha.1/microsoft.net.workload.mono.toolchain.net7/WorkloadManifest.targets 8.0.100-alpha.1/microsoft.net.workload.mono.toolchain/WorkloadManifest.targets Where the third one should be imported first for this to work. I believe this broke in 5f3deea, which inadvertently put these files in the `8.0.100-alpha.1` directory instead of `8.0.100`. The "baseline" version is always imported first, which is `8.0.100`: https://github.com/dotnet/installer/blob/c09cc8aada26be846359961fe160b5eff528d9df/src/redist/targets/BundledManifests.targets#L9-L13 Move the location of these files to hopefully fix this issue.
|
It appears this change doesn't break a local mac build for me: And then it also fixes the failing tests? |
grendello
approved these changes
Nov 4, 2022
pjcollins
approved these changes
Nov 4, 2022
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 7, 2022
* main: [xaprepare] use 8.0.100 version band for Mono workloads (dotnet#7530)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 9, 2022
* main: [docs] notes on binding `gradle-wrapper.jar` (dotnet#7529) [NuGet] Add back the `dotnet7` feed (dotnet#7534) [xaprepare] use 8.0.100 version band for Mono workloads (dotnet#7530)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#77385
Building
net6.0-androidandnet7.0-androidapps with .NET 8 is failing with:The problem appears to be due to the import ordering:
Where the third one should be imported first for this to work.
I believe this broke in 5f3deea, which inadvertently put these files in the
8.0.100-alpha.1directory instead of8.0.100.The "baseline" version is always imported first, which is
8.0.100:https://github.com/dotnet/installer/blob/c09cc8aada26be846359961fe160b5eff528d9df/src/redist/targets/BundledManifests.targets#L9-L13
Move the location of these files to hopefully fix this issue.