Skip to content

Commit 5f3deea

Browse files
[build] fix 8.0.100-alpha.1 version band (#7500)
Local builds were failing with: make prepare all … build-tools/create-packs/Directory.Build.targets(280,5): error MSB3073: The command ""…/xamarin-android/bin/Debug/dotnet/dotnet" workload install android-deps --configfile "…/xamarin-android/NuGet.config" --skip-manifest-update --verbosity diag" exited with code 1. `android-deps` is our workaround for installing the "abstract" Mono workload that we need to build against. Since we are "inventing" this workload, there is not a way for the .NET workload system to fall back to older version bands. And so: bin/Debug/lib/sdk-manifests/8.0.100/android.deps.workload/WorkloadManifest.json Doesn't work because the version band is *actually* 8.0.100-alpha.1. Update our logic in `eng/Versions.props` to support `alpha` version bands.
1 parent b5678d7 commit 5f3deea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<PropertyGroup>
1414
<!-- Match the first three version numbers and append 00 -->
1515
<DotNetPreviewVersionBand Condition=" '$(DotNetPreviewVersionBand)' == '' ">$([System.Text.RegularExpressions.Regex]::Match($(MicrosoftDotnetSdkInternalPackageVersion), `^\d+\.\d+\.\d`))00</DotNetPreviewVersionBand>
16-
<DotNetSdkManifestsFolder>$(DotNetPreviewVersionBand)$([System.Text.RegularExpressions.Regex]::Match($(MicrosoftDotnetSdkInternalPackageVersion), `\-(preview|rc).\d+`))</DotNetSdkManifestsFolder>
16+
<DotNetSdkManifestsFolder>$(DotNetPreviewVersionBand)$([System.Text.RegularExpressions.Regex]::Match($(MicrosoftDotnetSdkInternalPackageVersion), `\-(preview|rc|alpha).\d+`))</DotNetSdkManifestsFolder>
1717
<!-- NOTE: sometimes we hardcode these when transitioning to new version bands -->
1818
<DotNetAndroidManifestVersionBand>$(DotNetPreviewVersionBand)</DotNetAndroidManifestVersionBand>
1919
<DotNetMonoManifestVersionBand>8.0.100</DotNetMonoManifestVersionBand>

0 commit comments

Comments
 (0)