Fix loading of refonly assemblies for "classic" apps #7094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#7091 Context: dotnet@e1af958 e1af958 refactored a handful of `MonoImage` loading methods and during that process, I mistakenly made reference-only assemblies to be loaded in a "full" way which broke a number of BCL tests. Fix the issue by making sure reference-only assemblies are really loaded as such.
dellis1972
approved these changes
Jun 14, 2022
pjcollins
approved these changes
Jun 14, 2022
Member
|
We currently have issues with test result publishing in CI, but looking at the job the test step is now passing so I think this should be ready to merge: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7091
Context: e1af958
e1af958 refactored a handful of
MonoImageloading methods andduring that process, I mistakenly made reference-only assemblies
to be loaded in a "full" way which broke a number of BCL tests.
Fix the issue by making sure reference-only assemblies are really
loaded as such.