Fix loading of refonly assemblies for "classic" apps (#7094)

grendello · web-flow · commit 8070679103ab · 2022-06-14T17:25:54.000Z
Fixes: #7091 Context: e1af958 e1af958 refactored a handful of `MonoImage` loading methods and during that process, I mistakenly made reference-only assemblies to be loaded in a "full" way which broke a number of BCL tests. Fix the issue by making sure reference-only assemblies are really loaded as such.
diff --git a/src/monodroid/jni/embedded-assemblies.cc b/src/monodroid/jni/embedded-assemblies.cc
@@ -500,7 +500,7 @@ EmbeddedAssemblies::open_from_bundles (MonoAssemblyLoadContextGCHandle alc_gchan
 MonoAssembly*
 EmbeddedAssemblies::open_from_bundles_refonly (MonoAssemblyName *aname, [[maybe_unused]] char **assemblies_path, [[maybe_unused]] void *user_data)
 {
-	constexpr bool ref_only = false;
+	constexpr bool ref_only = true;
 
 	return embeddedAssemblies.open_from_bundles (aname, ref_only /* loader_data */, nullptr /* error */, ref_only);
 }

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,7 @@ EmbeddedAssemblies::open_from_bundles (MonoAssemblyLoadContextGCHandle alc_gchan`
`500`	`500`	`MonoAssembly*`
`501`	`501`	`EmbeddedAssemblies::open_from_bundles_refonly (MonoAssemblyName aname, [[maybe_unused]] char assemblies_path, [[maybe_unused]] void user_data)`
`502`	`502`	`{`
`503`		`- constexpr bool ref_only = false;`
	`503`	`+ constexpr bool ref_only = true;`
`504`	`504`
`505`	`505`	`return embeddedAssemblies.open_from_bundles (aname, ref_only /* loader_data /, nullptr / error */, ref_only);`
`506`	`506`	`}`