Skip to content

[Xamarin.Android.Build.Tasks] Xamarin.Android "Clean" target does not remove old .mdb files for library projects after Xamarin 15.2 release (Mono 5.0), leading to out-of-date debugging symbols for Fast Deployment mode #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017
Merged

[Xamarin.Android.Build.Tasks] Xamarin.Android "Clean" target does not remove old .mdb files for library projects after Xamarin 15.2 release (Mono 5.0), leading to out-of-date debugging symbols for Fast Deployment mode #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Tasks/GetFilesThatExist.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,19 @@ public class GetFilesThatExist : Task
[Required]
public ITaskItem[] Files { get; set; }

public ITaskItem [] IgnoreFiles { get; set; }

[Output]
public ITaskItem[] FilesThatExist { get; set; }

public override bool Execute ()
{
Log.LogDebugMessage ("GetFilesThatExist Task");
Log.LogDebugTaskItems (" Files", Files);
Log.LogDebugTaskItems (" IgnoreFiles", IgnoreFiles);

FilesThatExist = Files.Where (p => File.Exists (p.ItemSpec)).ToArray ();
FilesThatExist = Files.Where (p => File.Exists (p.ItemSpec) &&
(!IgnoreFiles?.Contains (p, TaskItemComparer.DefaultComparer) ?? true)).ToArray ();

Log.LogDebugTaskItems (" [Output] FilesThatExist", FilesThatExist);

Expand Down
7 changes: 5 additions & 2 deletions src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,9 +1497,12 @@ because xbuild doesn't support framework reference assemblies.

<Target Name="_CollectMdbFiles"
Inputs="@(ResolvedAssemblies->'%(RootDir)%(Directory)%(Filename)%(Extension)')"
Outputs="@(ResolvedAssemblies->'%(RootDir)%(Directory)%(Filename)%(Extension).mdb')">
Outputs="@(ResolvedAssemblies->'%(RootDir)%(Directory)%(Filename)%(Extension).mdb')"
DependsOnTargets="_CollectPdbFiles">
<GetFilesThatExist
Files="@(ResolvedAssemblies->'%(RootDir)%(Directory)%(Filename)%(Extension).mdb')">
Files="@(ResolvedAssemblies->'%(RootDir)%(Directory)%(Filename)%(Extension).mdb')"
IgnoreFiles="@(_ResolvedPortablePdbFiles->'%(RootDir)%(Directory)%(Filename).dll.mdb')"
>
<Output TaskParameter="FilesThatExist" ItemName="_ResolvedMdbFiles" />
</GetFilesThatExist>
</Target>
Expand Down