[Xamarin.Android.Build.Tasks] Xamarin.Android "Clean" target does not remove old .mdb files for library projects after Xamarin 15.2 release (Mono 5.0), leading to out-of-date debugging symbols for Fast Deployment mode #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on 35686dc or later, so that this can actually build. (Or so I hope, given that the build for 35686dc is still in progress....) |
… remove old .mdb files for library projects after Xamarin 15.2 release (Mono 5.0), leading to out-of-date debugging symbols for Fast Deployment mode Context https://bugzilla.xamarin.com/show_bug.cgi?id=57087 The latest mono has now switched over to using csc for its compiler. So we no longer generate .mdb files but instead generate portable .pdb files. Our current system will favour mdb over ppdb. So this commit adds a check so that we will ignore .mdb files if we have a valid ppdb file present. While this does not fix the PCL bug mentioned in 57087, it will prevent those stale .mdb files making it into the final package or .__override__ directory.
jonpryor
pushed a commit
that referenced
this pull request
Jun 7, 2017
…627) [Xamarin.Android.Build.Tasks] Don't copy mdb files when ppdbs exists (#627) Context: https://bugzilla.xamarin.com/show_bug.cgi?id=57087 The Xamarin.Android `Clean` target does not remove old `.mdb` files for library projects after Xamarin 15.2 release (Mono 5.0), leading to out-of-date debugging symbols for Fast Deployment mode. The latest mono has now switched over to using csc for its compiler. So we no longer generate `.mdb` files but instead generate portable `.pdb` files. Our current system will favour `mdb` over `ppdb`. This commit adds a check so that we will ignore `.mdb` files if we have a valid ppdb file present. While this does not fix the PCL bug mentioned in 57087, it will prevent those stale `.mdb` files making it into the final package or `.__override__` directory.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 16, 2020
Changes: dotnet/java-interop@80b4667...c19794e * dotnet/java-interop@c19794e: [build] Support building with JetBrains OpenJDK 11 (dotnet#629) * dotnet/java-interop@6d7266d: [crc64] Change the hash prefix back to `crc64` (dotnet#628) * dotnet/java-interop@7fe3a11: [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (dotnet#627) * dotnet/java-interop@9b88ce7: [performance] Improve speed of our CRC-64 hasher (dotnet#624) * dotnet/java-interop@1032c0e: [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (dotnet#622) * dotnet/java-interop@93df5a2: [generator] simplify life with 'var' in generated code (dotnet#621) Various `.csproj` files updated to deal with changes from dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file and requires use of C# unsafe code.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 17, 2020
Changes: dotnet/java-interop@80b4667...c19794e * dotnet/java-interop@c19794e: [build] Support building with JetBrains OpenJDK 11 (dotnet#629) * dotnet/java-interop@6d7266d: [crc64] Change the hash prefix back to `crc64` (dotnet#628) * dotnet/java-interop@7fe3a11: [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (dotnet#627) * dotnet/java-interop@9b88ce7: [performance] Improve speed of our CRC-64 hasher (dotnet#624) * dotnet/java-interop@1032c0e: [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (dotnet#622) * dotnet/java-interop@93df5a2: [generator] simplify life with 'var' in generated code (dotnet#621) Various `.csproj` files updated to deal with changes from dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file and requires use of C# unsafe code. Bump the expected size of `apk-Release-Bundle`, because dotnet/java-interop@9b88ce7 increased the size of `Mono.Android.dll`.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 17, 2020
Changes: dotnet/java-interop@80b4667...c19794e * dotnet/java-interop@c19794e: [build] Support building with JetBrains OpenJDK 11 (dotnet#629) * dotnet/java-interop@6d7266d: [crc64] Change the hash prefix back to `crc64` (dotnet#628) * dotnet/java-interop@7fe3a11: [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (dotnet#627) * dotnet/java-interop@9b88ce7: [performance] Improve speed of our CRC-64 hasher (dotnet#624) * dotnet/java-interop@1032c0e: [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (dotnet#622) * dotnet/java-interop@93df5a2: [generator] simplify life with 'var' in generated code (dotnet#621) Various `.csproj` files updated to deal with changes from dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file and requires use of C# unsafe code. Bump the expected sizes of `.apk` files, as dotnet/java-interop@9b88ce7 increased the size of `Mono.Android.dll`.
jonpryor
added a commit
that referenced
this pull request
Apr 18, 2020
Changes: dotnet/java-interop@80b4667...c19794e * dotnet/java-interop@c19794e: [build] Support building with JetBrains OpenJDK 11 (#629) * dotnet/java-interop@6d7266d: [crc64] Change the hash prefix back to `crc64` (#628) * dotnet/java-interop@7fe3a11: [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (#627) * dotnet/java-interop@9b88ce7: [performance] Improve speed of our CRC-64 hasher (#624) * dotnet/java-interop@1032c0e: [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (#622) * dotnet/java-interop@93df5a2: [generator] simplify life with 'var' in generated code (#621) Various `.csproj` files updated to deal with changes from dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file and requires use of C# unsafe code. Bump the expected sizes of `.apk` files, as dotnet/java-interop@9b88ce7 increased the size of `Mono.Android.dll`.
jonpryor
added a commit
that referenced
this pull request
Apr 23, 2020
Changes: dotnet/java-interop@ec4f819...6608c59 * dotnet/java-interop@6608c59 [generator] Fix generated code that caused CS0169 warnings. (#625) * dotnet/java-interop@0537eb1 Bump to xamarin/xamarin-android-tools/d16-7@310c5cf0 * dotnet/java-interop@59d86de [generator] Add nullable reference types (NRT) support. (#563) * dotnet/java-interop@64c2719 [build] Support building with JetBrains OpenJDK 11 (#629) * dotnet/java-interop@5a21381 [crc64] Change the hash prefix back to `crc64` (#628) * dotnet/java-interop@933876c [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (#627) * dotnet/java-interop@05c0d7d [performance] Improve speed of our CRC-64 hasher (#624) * dotnet/java-interop@6100554 [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (#622) * dotnet/java-interop@d736086 [generator] simplify life with 'var' in generated code (#621) Various `.csproj` files updated to deal with changes from dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file and requires use of C# unsafe code. Bump the expected sizes of `.apk` files, as dotnet/java-interop@9b88ce7 increased the size of `Mono.Android.dll`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://bugzilla.xamarin.com/show_bug.cgi?id=57087
The latest mono has now switched over to using csc for its
compiler. So we no longer generate .mdb files but instead
generate portable .pdb files.
Our current system will favour mdb over ppdb. So this commit
adds a check so that we will ignore .mdb files if we have a
valid ppdb file present. While this does not fix the PCL
bug mentioned in 57087, it will prevent those stale .mdb
files making it into the final package or .override
directory.