[One .NET] use AssemblyMetadataAttribute for IsTrimmable

[jonathanpeppers]

Fixes: #5638

Going forward in .NET 6, we shouldn't use the %(IsTrimmable)
metadata anymore, but use the following C# attribute in each assembly
instead:

[assembly: AssemblyMetadata ("IsTrimmable", "True")]

Similar changes on the iOS side here:

dotnet/macios@289053b

Bump to xamarin/java.interop/main@df4c5e7c

Changes: dotnet/java-interop@f9faaab...df4c5e7

This adds AssemblyMetadataAttribute for Java.Interop.dll.

[jonathanpeppers]

It appears that this change, causes many of the assemblies' sizes to increase:

Size difference in bytes ([*1] apk1 only, [*2] apk2 only):

188,703 assemblies/System.Net.Http.dll *2
142,573 assemblies/System.Private.Xml.dll *2
122,051 assemblies/System.Private.CoreLib.dll
 58,699 assemblies/System.Net.Security.dll *2
 58,248 assemblies/System.Security.Cryptography.X509Certificates.dll *2
 57,566 assemblies/System.Linq.Expressions.dll *2
 56,809 assemblies/System.Net.Sockets.dll *2
 52,297 assemblies/System.Text.RegularExpressions.dll *2
 44,316 assemblies/Mono.Android.dll
 42,052 assemblies/System.Net.Primitives.dll *2
 40,247 assemblies/System.Private.Uri.dll *2
 35,298 assemblies/Mono.Android.Export.dll *2
 28,176 assemblies/System.Formats.Asn1.dll *2
 26,943 assemblies/Java.Interop.dll
 25,938 assemblies/System.Security.Cryptography.Algorithms.dll *2
 19,205 assemblies/System.Runtime.Numerics.dll *2
 18,864 assemblies/System.IO.Compression.dll *2
 18,053 assemblies/System.Net.NetworkInformation.dll *2
 14,365 assemblies/System.Security.Cryptography.Encoding.dll *2
 13,934 assemblies/System.Threading.Channels.dll *2
 11,791 assemblies/System.IO.Compression.Brotli.dll *2
 11,347 assemblies/System.Collections.Concurrent.dll *2
 10,637 assemblies/System.Net.NameResolution.dll *2
  9,646 assemblies/System.Collections.NonGeneric.dll *2
  9,602 assemblies/System.Collections.dll *2
  7,538 assemblies/System.IO.FileSystem.dll *2
  5,786 assemblies/System.Security.Cryptography.Primitives.dll *2
  5,692 assemblies/System.Threading.dll *2
  5,020 assemblies/System.ObjectModel.dll *2
  3,760 assemblies/Microsoft.Win32.Primitives.dll *2
  3,283 assemblies/System.Runtime.InteropServices.dll *2
  3,089 assemblies/System.Runtime.InteropServices.RuntimeInformation.dll *2
  2,416 assemblies/System.Console.dll *2
  2,391 assemblies/System.Runtime.Extensions.dll *2
  2,306 assemblies/System.Reflection.Emit.dll *2
  2,284 assemblies/System.Reflection.Emit.ILGeneration.dll *2
  2,258 assemblies/System.Diagnostics.Debug.dll *2
  2,249 assemblies/System.Reflection.Emit.Lightweight.dll *2
  2,240 assemblies/System.Reflection.Primitives.dll *2
  2,212 assemblies/System.Threading.Thread.dll *2
  2,178 assemblies/System.Xml.ReaderWriter.dll *2
  1,619 assemblies/System.Runtime.dll
  1,487 assemblies/System.Runtime.CompilerServices.Unsafe.dll *2
  1,412 assemblies/System.Linq.dll
      5 assemblies/UnnamedProject.dll

Summary:
1,176,575 Assemblies 175.17% (of 671,690)

@sbomer is that expected? This might be one reason why iOS is larger than Android right now, they have this change already: dotnet/macios@289053b

[sbomer]

Nope, that's definitely not expected. Any chance you could share the linker command-line or a binlog?

[spouliot]

This might be one reason why iOS is larger than Android right now, they have this change already: dotnet/macios@289053b

No, this did not cause larger apps, nor any additional assemblies to be bundled. AFAICT it was a no op.

FWIW our apps were already larger before that recent commit :|

[jonathanpeppers]

@sbomer here is the log from that failing test above: msbuild.zip

Maybe the [assembly: AssemblyMetadata ("IsTrimmable", "True")] is somehow not in the assemblies I expect, checking on that.

[jonathanpeppers]

Ok, there is another Mono.Android.Export.dll that I added the attribute. Let's check if this fares any better.

[jonathanpeppers]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jonathanpeppers]

I think we're good here now, it was Mono.Android.Export.dll.

I'll need to land changes in java.interop first, then we can go about merging this.

[jonathanpeppers]

The two test failures seem to be unrelated:

error XA0010: Could not retrieve the Android ABI for the attached device or emulator. Please reconnect the device or restart the emulator, and try again.