Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/java-interop
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f9faaaba
Choose a base ref
...
head repository: dotnet/java-interop
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: df4c5e7c
Choose a head ref
  • 2 commits
  • 30 files changed
  • 2 contributors

Commits on Apr 22, 2021

  1. [generator] Separate metadata fixup step from parsing step. (#822)

    Context: #789
    
    One issue with the proposal to flip the order of `ApiXmlAdjuster` and
    `metadata` in Issue #789 is that the "apply metadata" step is
    intertwined with the "parse API xml document into POCO's" step.
    This means that the adjuster step cannot be inserted between them,
    as the code is currently written.
    
    Separate out the two steps so that they can be reordered in the future.
    
    Additionally, refactor the metadata fixup step so that it can be unit
    tested more easily by moving it to `Java.Interop.Tools.Generator.dll`.
    Unit tests for applying metadata have been added.
    jpobst authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    f4e68b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. [One .NET] specify AssemblyMetadataAttribute for IsTrimmable (#828)

    Context: dotnet/android#5638
    Context: dotnet/android#5879
    
    Going forward in .NET 6, we shouldn't use the `%(IsTrimmable)`
    metadata anymore, but instead use the following C# attribute in
    each assembly for which linking/"trimming" is supported:
    
    	[assembly: AssemblyMetadata ("IsTrimmable", "True")]
    
    Similar changes on the iOS side here:
    
      * dotnet/macios@289053b
    
    Add `AssemblyMetadataAttribute` to `Java.Interop.dll`.
    jonathanpeppers authored Apr 29, 2021
    Configuration menu
    Copy the full SHA
    df4c5e7 View commit details
    Browse the repository at this point in the history
Loading