[Xamarin.Android.Build.Tasks] fix _GeneratePackageManagerJavaForDesigner #3889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was doing some review of the MSBuild targets that run when you save
an axml file. The first thing I found was:
Building target "_GeneratePackageManagerJavaForDesigner" completely.
Output file "obj\Debug\100\android\src\mono\MonoPackageManager.java" does not exist.
This MSBuild target was running every time that
`SetupDependenciesForDesigner` runs.
We no longer generate `MonoPackageManager.java` at all, so instead:
* Look for `MonoPackageManager_Resources.java`, which actually exists.
* Use `$(_AcwMapFile)` instead of the typemaps, since the designer
actually uses that file. In some cases the typemaps aren't generated
either.
These changes improve `SetupDependenciesForDesigner` by about 500ms on
a small app.
dellis1972
approved these changes
Nov 8, 2019
jonpryor
pushed a commit
that referenced
this pull request
Nov 8, 2019
…ner (#3889) I was doing some review of the MSBuild targets that run when you save an axml file. The first thing I found was: Building target "_GeneratePackageManagerJavaForDesigner" completely. Output file "obj\Debug\100\android\src\mono\MonoPackageManager.java" does not exist. This MSBuild target was running every time that `SetupDependenciesForDesigner` runs. We no longer generate `MonoPackageManager.java` at all, so instead: * Look for `MonoPackageManager_Resources.java`, which actually exists. * Use `$(_AcwMapFile)` instead of the typemaps, since the designer actually uses that file. In some cases the typemaps aren't generated either. These changes improve `SetupDependenciesForDesigner` by about 500ms on a small app.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some review of the MSBuild targets that run when you save
an axml file. The first thing I found was:
This MSBuild target was running every time that
SetupDependenciesForDesignerruns.We no longer generate
MonoPackageManager.javaat all, so instead:MonoPackageManager_Resources.java, which actually exists.$(_AcwMapFile)instead of the typemaps, since the designeractually uses that file. In some cases the typemaps aren't generated
either.
These changes improve
SetupDependenciesForDesignerby about 500ms ona small app.