Commit fbb3342
authored
[Xamarin.Android.Build.Tasks] fix _GeneratePackageManagerJavaForDesigner (#3889)
I was doing some review of the MSBuild targets that run when you save
an axml file. The first thing I found was:
Building target "_GeneratePackageManagerJavaForDesigner" completely.
Output file "obj\Debug\100\android\src\mono\MonoPackageManager.java" does not exist.
This MSBuild target was running every time that
`SetupDependenciesForDesigner` runs.
We no longer generate `MonoPackageManager.java` at all, so instead:
* Look for `MonoPackageManager_Resources.java`, which actually exists.
* Use `$(_AcwMapFile)` instead of the typemaps, since the designer
actually uses that file. In some cases the typemaps aren't generated
either.
These changes improve `SetupDependenciesForDesigner` by about 500ms on
a small app.1 parent ebf1e51 commit fbb3342
File tree
2 files changed
+5
-3
lines changed- src/Xamarin.Android.Build.Tasks
- MSBuild/Xamarin/Android
- Tests/Xamarin.Android.Build.Tests
2 files changed
+5
-3
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
| 167 | + | |
167 | 168 | | |
168 | 169 | | |
169 | 170 | | |
170 | | - | |
| 171 | + | |
171 | 172 | | |
| 173 | + | |
172 | 174 | | |
173 | 175 | | |
174 | 176 | | |
| |||
0 commit comments