[build] fix Windows build on a fresh machine #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discovered the build fails on Windows if you: - wipe out `~\android-toolchain` - `git clean -dxf` - `msbuild Xamarin.Android.sln /t:Prepare` - Or just have a fresh machine We need to reorder the steps of what happens in `PrepareWindows.targets`: 1. `git submodule update` 2. build `xa-prep-tasks`, which gets `.nuget\NuGet.exe` 2. `nuget restore` 3. build `android-toolchain` , which is the missing step that installs the Android SDK 4. proceed with everything else Without step no. 3, the missing Android SDK that gets installed to `~\android-toolchain` causes the `<JdkInfo />` task to fail.
jonpryor
pushed a commit
that referenced
this pull request
Nov 3, 2020
Fixes: xamarin/monodroid#1129 Fixes: xamarin/monodroid#1130 Fixes: xamarin/monodroid#1131 Changes: xamarin/monodroid@04b0423...0eef889 * xamarin/monodroid@0eef88915: [tools/msbuild] workaround <FastDeploy/> hang in .NET 5 (#1134) * xamarin/monodroid@1ff611e08: [tools/msbuild] Terminate running app on FastDeploy. (#1132) * xamarin/monodroid@a9e5dd1c2: [tools/msbuild] Improved no device error messages for FastDeploy (#1133)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered the build fails on Windows if you:
~\android-toolchaingit clean -dxfmsbuild Xamarin.Android.sln /t:PrepareWe need to reorder the steps of what happens in
PrepareWindows.targets:git submodule updatexa-prep-tasks, which gets.nuget\NuGet.exenuget restoreandroid-toolchain, which is the missing step that installs the Android SDKWithout step no. 3, the missing Android SDK that gets installed to
~\android-toolchaincauses the<JdkInfo />task to fail.