Skip to content

[ci] Add API Scan job #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Mar 12, 2024
Merged

[ci] Add API Scan job #132

merged 26 commits into from
Mar 12, 2024

Conversation

pjcollins
Copy link
Member

Context: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/25351/APIScan-step-by-step-guide-to-setting-up-a-Pipeline

The ApiScan task has been added to pipeline runs against main. This
task should help us identify related issues earlier, rather than having
to wait for a full scan of VS.

Context: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/25351/APIScan-step-by-step-guide-to-setting-up-a-Pipeline

The ApiScan task has been added to pipeline runs against `main`.  This
task should help us identify related issues earlier, rather than having
to wait for a full scan of VS.
@pjcollins
Copy link
Member Author

pjcollins commented Jan 9, 2024

@pjcollins
Copy link
Member Author

The recommended method for suppressing known API Scan issues is to wait for the requested server exception list (SEL) changes to be approved and updated. This should be good to go with that in mind, but we may want to wait to merge until after the SEL is updated so that the new job will pass.

@pjcollins
Copy link
Member Author

Latest API scan run after 1ES template migration and rebasing: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9129458&view=results

@pjcollins pjcollins marked this pull request as ready for review February 23, 2024 18:48
@pjcollins
Copy link
Member Author

pjcollins commented Feb 26, 2024

Latest test run trying to match VS server exception list values: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9143026&view=results

@jonpryor jonpryor merged commit 8bc799c into main Mar 12, 2024
jonpryor pushed a commit to dotnet/android that referenced this pull request Jun 26, 2024
Context: #8988

Changes: dotnet/android-libzipsharp@3.1.1...3.3.0

  * dotnet/android-libzipsharp@de57dcc: Add xml comments. Centralize the dotnet target framework (dotnet/android-libzipsharp#143)
  * dotnet/android-libzipsharp@b541b87: Fix the elusive invalid zip archive issue that has been a problem for ages! (dotnet/android-libzipsharp#142)
  * dotnet/android-libzipsharp@c2ae332: Update OneLocBuildToken (dotnet/android-libzipsharp#141)
  * dotnet/android-libzipsharp@4fef46a: Bump library versions for the latest upstream releases (dotnet/android-libzipsharp#140)
  * dotnet/android-libzipsharp@14f591c: Remove LZMA (XZ) support (dotnet/android-libzipsharp#139)
  * dotnet/android-libzipsharp@336a86f: [ci] Use managed identity for API Scan (dotnet/android-libzipsharp#138)
  * dotnet/android-libzipsharp@8bc799c: [ci] Add API Scan job (dotnet/android-libzipsharp#132)
  * dotnet/android-libzipsharp@afef4b2: [ci] Improve binskim scan performance (dotnet/android-libzipsharp#137)
  * dotnet/android-libzipsharp@577147e: [ci] Migrate to the 1ES template (dotnet/android-libzipsharp#135)

Changes: xamarin/monodroid@c6aae9e...e11d9a5

  * xamarin/monodroid@e11d9a5af: Bump to LibZipSharp 3.3.0 (xamarin/monodroid#1493)
  * xamarin/monodroid@c9e71ebe5: Bump to xamarin/xamarin-android/main@eb7fdf7 (xamarin/monodroid#1495)
  * xamarin/monodroid@5c344d7c2: Bump to xamarin/android-sdk-installer@cc43d20d (xamarin/monodroid#1498)
  * xamarin/monodroid@004875391: Bump to xamarin/androidtools@0884384b (xamarin/monodroid#1496)

dotnet/android-libzipsharp@b541b87 fixes an odd corrupt zip file
issue which kept cropping up on our Azure Pipelines builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants