Skip to content

Commit de57dcc

Browse files
authored
Add xml comments. Centralize the dotnet target framework (#143)
1 parent b541b87 commit de57dcc

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

LibZipSharp.UnitTest/LibZipSharp.UnitTest.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<Import Project="$(MSBuildThisFileDirectory)..\LibZipSharp.props" />
44

55
<PropertyGroup>
6-
<TargetFrameworks>net471;net7.0;netcoreapp3.1</TargetFrameworks>
6+
<TargetFrameworks>net471;$(_DotNetTargetFramework);netcoreapp3.1</TargetFrameworks>
77

88
<IsPackable>false</IsPackable>
99
<LibZipSharpBundleAllNativeLibraries>true</LibZipSharpBundleAllNativeLibraries>

LibZipSharp.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<_LibZipSharpAssemblyVersion>$(_LibZipSharpAssemblyVersionMajor).$(_LibZipSharpAssemblyVersionMinor).$(_LibZipSharpAssemblyVersionPatch)</_LibZipSharpAssemblyVersion>
77
<_NativeLibraryVersionForName>$(_LibZipSharpAssemblyVersionMajor)-$(_LibZipSharpAssemblyVersionMinor)</_NativeLibraryVersionForName>
88
<_NativeLibraryBaseName>libZipSharpNative-$(_NativeLibraryVersionForName)</_NativeLibraryBaseName>
9+
<_DotNetTargetFramework>net7.0</_DotNetTargetFramework>
910

1011
<!--
1112
Nuget Version. You can append things like -alpha-1 etc to this value.

LibZipSharp/Xamarin.Tools.Zip/ZipArchive.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ ErrorCode Open (string path, OpenFlags flags)
196196
/// </summary>
197197
/// <param name="stream">The stream to open</param>
198198
/// <param name="options">Platform-specific options</param>
199-
/// <param name="strictConsistencyChecks"></param>
199+
/// <param name="strictConsistencyChecks">Perform strict consistency checks.</param>
200200
public static ZipArchive Open (Stream stream, IPlatformOptions options = null, bool strictConsistencyChecks = false)
201201
{
202202
OpenFlags flags = OpenFlags.None;
@@ -210,6 +210,7 @@ public static ZipArchive Open (Stream stream, IPlatformOptions options = null, b
210210
/// </summary>
211211
/// <param name="stream">The stream to create the arhive in</param>
212212
/// <param name="options">Platform-specific options</param>
213+
/// <param name="strictConsistencyChecks">Perform strict consistency checks.</param>
213214
public static ZipArchive Create (Stream stream, IPlatformOptions options = null, bool strictConsistencyChecks = false)
214215
{
215216
OpenFlags flags = OpenFlags.Create | OpenFlags.Truncate;

LibZipSharp/libZipSharp.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<PropertyGroup>
55
<AssemblyName>libZipSharp</AssemblyName>
66
<AssemblyTitle>libZipSharp</AssemblyTitle>
7-
<TargetFrameworks>net7.0;netstandard2.0;net45;netcoreapp3.1</TargetFrameworks>
7+
<TargetFrameworks>$(_DotNetTargetFramework);netstandard2.0;net45;netcoreapp3.1</TargetFrameworks>
88
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
<RootNamespace>Xamarin.Tools.Zip</RootNamespace>
@@ -46,7 +46,7 @@
4646
<Import Project="libZipSharp.targets" />
4747

4848
<ItemGroup>
49-
<None Include="$(IntermediateOutputPath)/net7.0/$(XamarinLibZipSharpTargetsName)" PackagePath="build" Pack="true" />
49+
<None Include="$(IntermediateOutputPath)/$(_DotNetTargetFramework)/$(XamarinLibZipSharpTargetsName)" PackagePath="build" Pack="true" />
5050
<None Include="$(_NativeBuildDir)\lib\Darwin\$(_NativeLibraryBaseName).dylib" PackagePath="runtimes\osx\native\$(_NativeLibraryBaseName).dylib" Pack="true" />
5151
<None Include="$(_NativeBuildDir)\lib\win64\$(_NativeLibraryBaseName).dll" PackagePath="runtimes\win-x64\native\$(_NativeLibraryBaseName).dll" Pack="true" />
5252
<None Include="$(_NativeBuildDir)\lib\win64\$(_NativeLibraryBaseName).pdb" PackagePath="runtimes\win-x64\native\$(_NativeLibraryBaseName).pdb" Pack="true" />

0 commit comments

Comments
 (0)