Skip to content

Change expected newline char when parsing crypto test baseline file. #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

Change expected newline char when parsing crypto test baseline file. #3690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbeb9b9
Change expected newline char when parsing file.
mdaigle Oct 14, 2025
d5983f8
Always run tests. Expected newline is os specific. Switch baselines b…
mdaigle Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CoreCryptoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@

namespace Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted
{
public class CoreCryptoTests : IClassFixture<SQLSetupStrategyCertStoreProvider>
public class CoreCryptoTests
{
// Synapse: Always Encrypted not supported in Azure Synapse.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[Fact]
public void TestAeadCryptoWithNativeBaseline()
{
// Initialize the reader for resource text file which has the native code generated baseline.
Expand Down Expand Up @@ -45,8 +44,7 @@ public void TestAeadCryptoWithNativeBaseline()
}
}

// Synapse: Always Encrypted not supported in Azure Synapse.
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[Fact]
public void TestRsaCryptoWithNativeBaseline()
{
// Initialize the reader for resource text file which has the native code generated baseline.
Expand Down
3 changes: 1 addition & 2 deletions ...Client/tests/ManualTests/AlwaysEncrypted/TestFixtures/Setup/CryptoNativeBaselineReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Linq;
using System.Text;
using System.Text.RegularExpressions;
using System.Threading.Tasks;

namespace Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.Setup
{
Expand Down Expand Up @@ -174,7 +173,7 @@ internal class CryptoNativeBaselineReader
/// <summary>
/// Parameter Data End identifier, to search inside resource text file.
/// </summary>
private static readonly Regex regexEndParameterIdentifier = new Regex(@"\r");
private static readonly Regex regexEndParameterIdentifier = new Regex(Environment.NewLine);

private readonly IList<CryptoVector> m_CryptoVectors;

Expand Down
Loading