Skip to content

Conversation

@mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Oct 14, 2025

Description

CoreCryptoTests fail when run on linux because line endings are normalized to LF when the repo is checked out. The tests are otherwise still applicable to linux and can pass when the "baseline" files containing the keypairs are properly parsed.

This PR:

  • Adjusts keypair files to use LF in place of CRLF.
    • This doesn't show in the diff, unfortunately.
  • Adjust file parsing to look for LF.

Successful run: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=127269&view=results

@mdaigle mdaigle marked this pull request as ready for review October 14, 2025 21:43
@mdaigle mdaigle requested a review from a team as a code owner October 14, 2025 21:43
Copilot AI review requested due to automatic review settings October 14, 2025 21:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CoreCryptoTests that were failing on Linux due to line ending differences. The tests parse baseline files containing keypairs, which use CRLF on Windows but are normalized to LF on Linux checkout.

  • Updated regex pattern to look for LF (\n) instead of CRLF (\r) when parsing parameter data
  • Adjusted baseline keypair files to use LF line endings (not visible in diff)

@paulmedynski paulmedynski self-assigned this Oct 14, 2025
@mdaigle mdaigle changed the title Change expected newline char when parsing file. Change expected newline char when parsing crypto baseline file. Oct 14, 2025
@mdaigle mdaigle changed the title Change expected newline char when parsing crypto baseline file. Change expected newline char when parsing crypto test baseline file. Oct 14, 2025
@cheenamalhotra
Copy link
Member

cheenamalhotra commented Oct 15, 2025

I still see failures in Windows jobs in the linked build, is that expected?

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (2d05980) to head (d5983f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3690      +/-   ##
==========================================
+ Coverage   77.34%   77.36%   +0.02%     
==========================================
  Files         271      271              
  Lines       45245    45245              
==========================================
+ Hits        34993    35003      +10     
+ Misses      10252    10242      -10     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore 77.34% <ø> (+0.02%) ⬆️
netfx 76.51% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle merged commit 3867bbb into main Oct 15, 2025
258 checks passed
@mdaigle mdaigle deleted the dev/mdaigle/fix-crypto-tests-linux branch October 15, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants