-
Notifications
You must be signed in to change notification settings - Fork 317
Change expected newline char when parsing crypto test baseline file. #3690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes CoreCryptoTests that were failing on Linux due to line ending differences. The tests parse baseline files containing keypairs, which use CRLF on Windows but are normalized to LF on Linux checkout.
- Updated regex pattern to look for LF (
\n) instead of CRLF (\r) when parsing parameter data - Adjusted baseline keypair files to use LF line endings (not visible in diff)
...SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/Setup/CryptoNativeBaselineReader.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CoreCryptoTests.cs
Show resolved
Hide resolved
|
I still see failures in Windows jobs in the linked build, is that expected? |
cheenamalhotra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the correct build is https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=127290&view=results
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
+ Coverage 77.34% 77.36% +0.02%
==========================================
Files 271 271
Lines 45245 45245
==========================================
+ Hits 34993 35003 +10
+ Misses 10252 10242 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
CoreCryptoTests fail when run on linux because line endings are normalized to LF when the repo is checked out. The tests are otherwise still applicable to linux and can pass when the "baseline" files containing the keypairs are properly parsed.
This PR:
Successful run: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=127269&view=results