Remove AKV Build from sqlclient-official build #3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrr101
added
the
Area\Engineering
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3187 +/- ##
==========================================
- Coverage 72.78% 72.56% -0.22%
==========================================
Files 285 289 +4
Lines 59137 59543 +406
==========================================
+ Hits 43043 43208 +165
- Misses 16094 16335 +241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
approved these changes
Feb 28, 2025
mdaigle
approved these changes
Feb 28, 2025
cheenamalhotra
approved these changes
Feb 28, 2025
|
Can you also please update BUILDGUIDE with instructions on how to build the AKV provider now with new changes. |
|
As per APIScan team, failures with builds are due to using the Unofficial onebranch template (which is required due to the build not being based on an approved PR. Once we can run Official onebranch template, behavior should be the same as before (ie, APIScan errors being ignored for passing the build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: With the completion and operationalization of #3150, we can finally remove AKV build from the sqlclient-official pipeline. This PR does just that!
Testing: Currently in progress, the main issue atm is that apiscan is throwing errors.