Remove AKV Build from sqlclient-official build (#3187)

* Remove the AKV pipeline from the current official MDS pipeline

* Removing MDS_PackageRef_Version

* Add target to build guide

Author: benrr101

BUILDGUIDE.md

@@ -30,6 +30,7 @@ Once the environment is setup properly, execute the desired set of commands belo
 |`RunTests`|Runs the functional and manual tests for the .NET Framework and .NET drivers|
 |`RunFunctionalTests`|Runs just the functional tests for the .NET Framework and .NET drivers|
 |`RunManualTests`|Runs just the manual tests for the .NET Framework and .NET drivers|
+|`BuildAkv`|Builds the Azure Key Vault Provider package for all supported platforms.|
 
 
 ### Parameters

eng/pipelines/common/templates/jobs/build-signed-akv-package-job.yml

@@ -20,7 +20,6 @@ parameters:
     default: MDS
     values:
     - MDS
-    - AKV
     - MSS
 
 steps:
@@ -49,18 +48,3 @@ steps:
       solution: '**/build.proj'
       configuration: '${{parameters.Configuration }}'
       msbuildArguments: '-p:AssemblyFileVersion=${{parameters.AssemblyFileVersion }} -t:BuildAllConfigurations -p:GenerateNuget=false -p:SigningKeyPath=$(Agent.TempDirectory)\netfxKeypair.snk'
-
-- ${{ if eq(parameters.product, 'AKV') }}:
-  - task: MSBuild@1
-    displayName: 'BuildAKVNetFx using build.proj'
-    inputs:
-      solution: '**/build.proj'
-      configuration: '${{parameters.Configuration }}'
-      msbuildArguments: '-p:AssemblyFileVersion=${{parameters.AssemblyFileVersion }} -t:BuildAKVNetFx -p:NugetPackageVersion=${{parameters.packageRefMdsVersion }} -p:ReferenceType=Package -p:SigningKeyPath=$(Agent.TempDirectory)\netfxKeypair.snk'
-
-  - task: MSBuild@1
-    displayName: 'BuildAKVNetCoreAllOS using build.proj'
-    inputs:
-      solution: '**/build.proj'
-      configuration: '${{parameters.Configuration }}'
-      msbuildArguments: '-p:AssemblyFileVersion=${{parameters.AssemblyFileVersion }} -t:BuildAKVNetCoreAllOS -p:NugetPackageVersion=${{parameters.packageRefMdsVersion }} -p:ReferenceType=Package -p:SigningKeyPath=$(Agent.TempDirectory)\netfxKeypair.snk'

eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml

@@ -22,7 +22,6 @@ parameters:
     default: MDS
     values:
     - MDS
-    - AKV
     - MSS
 
 steps:
@@ -35,14 +34,6 @@ steps:
         msBuildArchitecture: x64
         setupCommandlinePicker: vs2022
         msBuildCommandline: 'msbuild  ${{parameters.sourceRoot}}\build.proj -p:configuration=Release -p:GenerateNuget=false -p:BuildTools=false -p:SigningKeyPath=$(Agent.TempDirectory)\netfxKeypair.snk'
-  - ${{ if eq(parameters.product, 'AKV') }}:
-    - task: securedevelopmentteam.vss-secure-development-tools.build-task-roslynanalyzers.RoslynAnalyzers@3
-      displayName: 'Guardian Dotnet Analyzers '
-      inputs:
-        msBuildVersion: 17.0
-        msBuildArchitecture: x64
-        setupCommandlinePicker: vs2022
-        msBuildCommandline: 'msbuild  ${{parameters.sourceRoot}}\build.proj -p:configuration=Release -p:GenerateNuget=false -p:BuildTools=false -p:NugetPackageVersion=${{parameters.packageRefMdsVersion }} -p:ReferenceType=Package -t:BuildAKVNetCoreAllOS -p:SigningKeyPath=$(Agent.TempDirectory)\netfxKeypair.snk'
 
 - ${{ if or(eq(parameters.analyzeType, 'inspect'), eq(parameters.analyzeType, 'all')) }}:
   - task: securedevelopmentteam.vss-secure-development-tools.build-task-codeinspector.CodeInspector@2

eng/pipelines/common/templates/steps/code-analyze-step.yml

@@ -33,7 +33,6 @@ parameters:
     default: MDS
     values:
     - MDS
-    - AKV
     - MSS
 
 steps:
@@ -80,23 +79,6 @@ steps:
         Get-Location
       displayName: 'Prepare ${{ targetFramework }} Artifacts for Testing'
 
-  - ${{ if eq(parameters.product, 'AKV') }}:
-    - powershell: |
-        $software = '${{parameters.softwareFolder}}'
-        $tf = '${{ targetFramework }}'
-        md $software\win\$tf
-        
-        Copy-Item "artifacts\${{parameters.referenceType }}\bin\Windows_NT\${{parameters.Configuration }}.AnyCPU\AzureKeyVaultProvider\$tf\Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.dll" "$software\win\$tf" -recurse
-        
-        $symbols = '${{parameters.symbolsFolder}}'
-        md $symbols\win\$tf
-        
-        Copy-Item "artifacts\${{parameters.referenceType }}\bin\Windows_NT\${{parameters.Configuration }}.AnyCPU\AzureKeyVaultProvider\$tf\Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.pdb" "$symbols\win\$tf" -recurse
-            
-        Write-Host "Artifacts fetched for testing"
-        Get-Location
-      displayName: 'Prepare ${{ targetFramework }} Artifacts for Testing'
-
 - powershell: |
     $software = '${{parameters.softwareFolder}}'
     $symbols = '${{parameters.symbolsFolder}}'

eng/pipelines/common/templates/steps/copy-dlls-for-test-step.yml

@@ -45,7 +45,6 @@ parameters:
     default: MDS
     values:
     - MDS
-    - AKV
     - MSS
 
 steps:
@@ -71,24 +70,6 @@ steps:
       Pat: $(System.AccessToken)
     condition: and(succeeded(), ${{ eq(parameters.publishSymbols, 'true') }})
 
-- ${{ if eq(parameters.product, 'AKV') }}:
-  - task: PublishSymbols@2
-    displayName: 'Upload symbols to ${{parameters.SymAccount }} org'
-    inputs:
-      SymbolsFolder: '$(Build.SourcesDirectory)\artifacts\${{parameters.referenceType }}\bin'
-      SearchPattern: |
-        Windows_NT/$(Configuration).AnyCPU/AzureKeyVaultProvider/**/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.pdb
-        AnyOS/$(Configuration).AnyCPU/AzureKeyVaultProvider/**/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.pdb
-      IndexSources: false
-      SymbolServerType: TeamServices
-      SymbolsMaximumWaitTime: 60
-      SymbolExpirationInDays: 1825 # 5 years
-      SymbolsProduct: Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
-      SymbolsVersion: ${{parameters.symbolsVersion }}
-      SymbolsArtifactName: ${{parameters.symbolsArtifactName }}
-      Pat: $(System.AccessToken)
-    condition: and(succeeded(), ${{ eq(parameters.publishSymbols, 'true') }})
-
 - task: AzureCLI@2
   displayName: 'Publish symbols'
   condition: and(succeeded(), ${{ eq(parameters.publishSymbols, 'true') }})

eng/pipelines/common/templates/steps/publish-symbols-step.yml

@@ -45,11 +45,6 @@ parameters: # parameters are shown up in ADO UI in a build queue time
   type: boolean
   default: false
 
-- name: MDS_PackageRef_Version
-  displayName: 'MDS package version of AKV Provider (build AKV)'
-  type: string
-  default: 5.1.5
-
 - name: CurrentNetFxVersion
   displayName: 'Lowest supported .NET Framework version (MDS validation)'
   type: string
@@ -73,8 +68,6 @@ variables:
     value: drop_buildMDS_build_signed_package
   - name: PublishSymbols
     value: ${{ parameters['publishSymbols'] }}
-  - name: MDS_PackageRef_Version
-    value: ${{ parameters['MDS_PackageRef_Version'] }}
   - name: CurrentNetFxVersion
     value: ${{ parameters['CurrentNetFxVersion'] }}
 
@@ -130,15 +123,6 @@ extends:
         tsaOptionsPath: $(REPOROOT)\.config\tsaoptions.json
         disableLegacyManifest: true
     stages:
-    - stage: buildAKV
-      displayName: 'Build AKV Provider'
-      jobs:
-      - template: eng/pipelines/common/templates/jobs/build-signed-akv-package-job.yml@self
-        parameters:
-          symbolsFolder: $(symbolsFolder)
-          softwareFolder: $(softwareFolder)
-          publishSymbols: ${{ parameters['publishSymbols'] }}
-
     - stage: buildMDS
       displayName: 'Build MDS'
       jobs:

eng/pipelines/dotnet-sqlclient-signing-pipeline.yml

@@ -6,5 +6,4 @@
 
 variables:
   - template: common-variables.yml@self
-  - template: akv-variables.yml@self
   - template: mds-variables.yml@self

eng/pipelines/libraries/akv-variables.yml

@@ -234,7 +234,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "templates", "templates", "{
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "jobs", "jobs", "{3850810F-535E-443A-A9B4-7EE85B327E0A}"
 	ProjectSection(SolutionItems) = preProject
-		..\eng\pipelines\common\templates\jobs\build-signed-akv-package-job.yml = ..\eng\pipelines\common\templates\jobs\build-signed-akv-package-job.yml
 		..\eng\pipelines\common\templates\jobs\build-signed-package-job.yml = ..\eng\pipelines\common\templates\jobs\build-signed-package-job.yml
 		..\eng\pipelines\common\templates\jobs\ci-build-nugets-job.yml = ..\eng\pipelines\common\templates\jobs\ci-build-nugets-job.yml
 		..\eng\pipelines\common\templates\jobs\ci-code-coverage-job.yml = ..\eng\pipelines\common\templates\jobs\ci-code-coverage-job.yml
@@ -275,7 +274,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "steps", "steps", "{EABE3A3E
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "libraries", "libraries", "{75BAE755-3A1F-41F2-9176-9F8FF9FEE2DD}"
 	ProjectSection(SolutionItems) = preProject
-		..\eng\pipelines\libraries\akv-variables.yml = ..\eng\pipelines\libraries\akv-variables.yml
 		..\eng\pipelines\libraries\build-variables.yml = ..\eng\pipelines\libraries\build-variables.yml
 		..\eng\pipelines\libraries\ci-build-variables.yml = ..\eng\pipelines\libraries\ci-build-variables.yml
 		..\eng\pipelines\libraries\common-variables.yml = ..\eng\pipelines\libraries\common-variables.yml