Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build guide and docs after net6 removal #2944

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Clean up build guide and docs after net6 removal #2944

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8c8690
Updating readme
mdaigle Oct 30, 2024
9e60b71
Merge branch 'main' of github.com:dotnet/SqlClient into final-net6-cl…
mdaigle Oct 31, 2024
7787dcd
Clean up build guide. Remove Net5 accommodating code from test.
mdaigle Oct 31, 2024
d74afb1
Revert test change.
mdaigle Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert test change.
  • Loading branch information
@mdaigle
mdaigle committed Nov 5, 2024
commit d74afb16db4d9a85d28296819f9f93b4d7c20589
7 changes: 5 additions & 2 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,10 +1556,13 @@ private static void ReadStream(string connectionString)
DataTestUtility.AssertThrowsWrapper<ArgumentOutOfRangeException>(() => stream.Read(buffer, -1, 2));
DataTestUtility.AssertThrowsWrapper<ArgumentOutOfRangeException>(() => stream.Read(buffer, 2, -1));

// Prior to net6 comment:ArgumentException is thrown in net5 and earlier. ArgumentOutOfRangeException in net6 and later
ArgumentException ex = Assert.ThrowsAny<ArgumentException>(() => stream.Read(buffer, buffer.Length, buffer.Length));
Assert.True(ex.GetType() == typeof(ArgumentOutOfRangeException));
Assert.True(ex.GetType() == typeof(ArgumentException) || ex.GetType() == typeof(ArgumentOutOfRangeException),
"Expected: ArgumentException in net5 and earlier. ArgumentOutOfRangeException in net6 and later.");
ex = Assert.ThrowsAny<ArgumentException>(() => stream.Read(buffer, int.MaxValue, int.MaxValue));
Assert.True(ex.GetType() == typeof(ArgumentOutOfRangeException));
Assert.True(ex.GetType() == typeof(ArgumentException) || ex.GetType() == typeof(ArgumentOutOfRangeException),
"Expected: ArgumentException in net5 and earlier. ArgumentOutOfRangeException in net6 and later.");
}

// Once Reader is closed
Expand Down
Loading