Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build guide and docs after net6 removal #2944

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Oct 31, 2024

Restructures the buildguide document. Adds a reference section and a workflows section. Previously, the doc was structured as a collection of example commands, but it didn't clearly call out dependencies (e.g. building tests before running them and how to do so for that type of test run) and was a poor way to discover and understand the MSBuild targets and parameters.

Also includes small doc and test updates to remove .NET6 references.

@mdaigle mdaigle added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Oct 31, 2024
@mdaigle mdaigle added this to the 6.0-preview3 milestone Oct 31, 2024
@mdaigle
Copy link
Contributor Author

mdaigle commented Nov 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdaigle
Copy link
Contributor Author

mdaigle commented Nov 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fc0acc0). Learn more about missing BASE report.
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2944   +/-   ##
=======================================
  Coverage        ?   72.31%           
=======================================
  Files           ?      288           
  Lines           ?    59660           
  Branches        ?        0           
=======================================
  Hits            ?    43141           
  Misses          ?    16519           
  Partials        ?        0           
Flag Coverage Δ
addons 92.58% <ø> (?)
netcore 75.41% <ø> (?)
netfx 70.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdaigle mdaigle merged commit a604a66 into dotnet:main Nov 5, 2024
76 checks passed
@mdaigle mdaigle deleted the final-net6-cleanup branch November 5, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants