Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDS8 Add Server Certificate Support #1822

Merged
merged 25 commits into from
Nov 10, 2022
Merged

TDS8 Add Server Certificate Support #1822

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c6edb95
Add ServerCertificate as a keyword and reference it in the api calls
lcheunglci Sep 27, 2022
a35356b
Update functional test for the keyword support for server certificate
lcheunglci Sep 27, 2022
d968a22
Update the string resource file for HostNameInCertificate and ServerC…
lcheunglci Sep 27, 2022
f3e9703
Remove unreferenced tlsFirst param and set the server certificate in …
lcheunglci Sep 27, 2022
2dc03ef
Increment the SynonymCount by 1 for the new keyword
lcheunglci Sep 28, 2022
1d4aaea
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Oct 31, 2022
54080fa
Fix compiler errors
lcheunglci Oct 31, 2022
9072bbf
Fix the SNIAuthProviderInfo struct due to missing certificate context…
lcheunglci Oct 31, 2022
41da383
Add server certificate validation for netcore
lcheunglci Nov 1, 2022
1f5b57e
Add fix to netcore due to mismatch struct
lcheunglci Nov 1, 2022
c4512d3
Revert netfx compiler fix caused by local project targetframework
lcheunglci Nov 1, 2022
5e18eb1
Address comments and renamed serverCert to serverCertificateFilename
lcheunglci Nov 1, 2022
fd4f27b
Fix typo
lcheunglci Nov 1, 2022
e1b6a91
Fix typo
lcheunglci Nov 1, 2022
de5ef6d
Resolve merge conflict
lcheunglci Nov 2, 2022
bf536c4
Add ServerCertificate in the netfx ref project
lcheunglci Nov 2, 2022
191f2b3
Add documentation to ServerCertificate and HNIC in SqlConnectionBuild…
lcheunglci Nov 2, 2022
6e7a0d8
Apply suggestions from code review
lcheunglci Nov 3, 2022
b08ccd9
Update documentation re: encrypt mode for HNIC and ServerCertificate
lcheunglci Nov 4, 2022
a54bfc3
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Nov 7, 2022
01a6f58
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Nov 8, 2022
c364903
Apply suggestions from code review
lcheunglci Nov 9, 2022
b89fa5e
Address comments
lcheunglci Nov 10, 2022
02dd347
Merge branch 'TDS8-Add-ServerCertificate-Support' of https://github.c…
lcheunglci Nov 10, 2022
1c26fff
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@lcheunglci
lcheunglci committed Nov 1, 2022
commit fd4f27bb900b760e6d27a1b1940d956634194374
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionString.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ internal static class KEY
internal const string Current_Language = DbConnectionStringKeywords.CurrentLanguage;
internal const string Data_Source = DbConnectionStringKeywords.DataSource;

// Encrpyt related
// Encrypt related
internal const string Encrypt = DbConnectionStringKeywords.Encrypt;
internal const string HostNameInCertificate = DbConnectionStringKeywords.HostNameInCertificate;
internal const string ServerCertificate = DbConnectionStringKeywords.ServerCertificate;
Expand Down