Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDS8 Add Server Certificate Support #1822

Merged
merged 25 commits into from
Nov 10, 2022
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c6edb95
Add ServerCertificate as a keyword and reference it in the api calls
lcheunglci Sep 27, 2022
a35356b
Update functional test for the keyword support for server certificate
lcheunglci Sep 27, 2022
d968a22
Update the string resource file for HostNameInCertificate and ServerC…
lcheunglci Sep 27, 2022
f3e9703
Remove unreferenced tlsFirst param and set the server certificate in …
lcheunglci Sep 27, 2022
2dc03ef
Increment the SynonymCount by 1 for the new keyword
lcheunglci Sep 28, 2022
1d4aaea
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Oct 31, 2022
54080fa
Fix compiler errors
lcheunglci Oct 31, 2022
9072bbf
Fix the SNIAuthProviderInfo struct due to missing certificate context…
lcheunglci Oct 31, 2022
41da383
Add server certificate validation for netcore
lcheunglci Nov 1, 2022
1f5b57e
Add fix to netcore due to mismatch struct
lcheunglci Nov 1, 2022
c4512d3
Revert netfx compiler fix caused by local project targetframework
lcheunglci Nov 1, 2022
5e18eb1
Address comments and renamed serverCert to serverCertificateFilename
lcheunglci Nov 1, 2022
fd4f27b
Fix typo
lcheunglci Nov 1, 2022
e1b6a91
Fix typo
lcheunglci Nov 1, 2022
de5ef6d
Resolve merge conflict
lcheunglci Nov 2, 2022
bf536c4
Add ServerCertificate in the netfx ref project
lcheunglci Nov 2, 2022
191f2b3
Add documentation to ServerCertificate and HNIC in SqlConnectionBuild…
lcheunglci Nov 2, 2022
6e7a0d8
Apply suggestions from code review
lcheunglci Nov 3, 2022
b08ccd9
Update documentation re: encrypt mode for HNIC and ServerCertificate
lcheunglci Nov 4, 2022
a54bfc3
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Nov 7, 2022
01a6f58
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Nov 8, 2022
c364903
Apply suggestions from code review
lcheunglci Nov 9, 2022
b89fa5e
Address comments
lcheunglci Nov 10, 2022
02dd347
Merge branch 'TDS8-Add-ServerCertificate-Support' of https://github.c…
lcheunglci Nov 10, 2022
1c26fff
Merge branch 'main' into TDS8-Add-ServerCertificate-Support
lcheunglci Nov 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: David Engel <dengel1012@gmail.com>
  • Loading branch information
lcheunglci and David-Engel authored Nov 9, 2022
commit c364903d792cb6b67d85382c3c0f913707432e03
2 changes: 1 addition & 1 deletion doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ End Module
|Failover Partner|N/A|The name of the failover partner server where database mirroring is configured.<br /><br /> If the value of this key is "", then **Initial Catalog** must be present, and its value must not be "".<br /><br /> The server name can be 128 characters or less.<br /><br /> If you specify a failover partner but the failover partner server is not configured for database mirroring and the primary server (specified with the Server keyword) is not available, then the connection will fail.<br /><br /> If you specify a failover partner and the primary server is not configured for database mirroring, the connection to the primary server (specified with the Server keyword) will succeed if the primary server is available.|
|Failover Partner SPN<br /><br /> -or-<br /><br /> FailoverPartnerSPN|N/A|The SPN for the failover partner. The default value is an empty string, which causes SqlClient to use the default, driver-generated SPN.<br /><br /> (Only available in v5.0+)|
|Host Name In Certificate<br /><br /> -or-<br /><br />HostNameInCertificate|N/A|The host name to use when validating the server certificate. When not specified, the server name from the Data Source is used for certificate validation.<br /><br /> (Only available in v5.0+)|
|Server Certificate<br /><br /> -or-<br /><br />ServerCertificate|N/A|The path to a certificate file to match against the SQL Server TLS/SSL certificate. The accepted certificate formats are PEM, DER, and CER. If specified, the SQL Server certificate is checked by verifying if the ServerCertificate provided is an exact match.<br /><br /> (Only available in v5.0+)|
|Server Certificate<br /><br /> -or-<br /><br />ServerCertificate|N/A|The path to a certificate file to match against the SQL Server TLS/SSL certificate. The accepted certificate formats are PEM, DER, and CER. If specified, the SQL Server certificate is checked by verifying if the ServerCertificate provided is an exact match.<br /><br /> (Only available in v5.1+)|
|Initial Catalog<br /><br /> -or-<br /><br /> Database|N/A|The name of the database.<br /><br /> The database name can be 128 characters or less.|
|Integrated Security<br /><br /> -or-<br /><br /> Trusted_Connection|'false'|When `false`, User ID and Password are specified in the connection. When `true`, the current Windows account credentials are used for authentication.<br /><br /> Recognized values are `true`, `false`, `yes`, `no`, and `sspi` (strongly recommended), which is equivalent to `true`.<br /><br /> If User ID and Password are specified and Integrated Security is set to true, the User ID and Password will be ignored and Integrated Security will be used.<br /><br /> <xref:Microsoft.Data.SqlClient.SqlCredential> is a more secure way to specify credentials for a connection that uses SQL Server Authentication (`Integrated Security=false`).|
|IP Address Preference<br /><br /> -or-<br /><br /> IPAddressPreference|IPv4First|The IP address family preference when establishing TCP connections. If `Transparent Network IP Resolution` (in .NET Framework) or `Multi Subnet Failover` is set to true, this setting has no effect. Supported values include:<br /><br /> `IPAddressPreference=IPv4First`<br /><br />`IPAddressPreference=IPv6First`<br /><br />`IPAddressPreference=UsePlatformDefault`|
Expand Down