Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-user key store provider registration support #1056
Add multi-user key store provider registration support #1056
Changes from 27 commits
aa57be4
3343f11
3817594
561b703
1fe38ef
89f0467
d230367
814f2d5
cd44659
ecb7171
2ad5fc0
13e9344
c45dc23
f2be4b2
4319ab7
36f6c0a
c79d95c
cc762ed
2d7ca05
dbdba21
1fa3c47
68f24f7
ba28eba
2842c71
bef6ec7
c7f07c9
6fdc8bd
46eab82
b964ce6
8d486ee
b488f79
2f1afc4
5d93ef4
1c55226
74b06b6
ac4ff87
d73a9d2
6ad4eb9
c5dd485
9dea525
4707ff2
6eccf60
38923d1
5b111d9
4494979
82e8c7b
1a254d7
1ebe277
324e2e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: this naming convention seems a bit insufficient. Is it possible to change it to GetOrCreateLocalCache or something more explanatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not getting/creating a local cache. It's getting/creating the given key. When used, it makes sense to me, e.g.
columnEncryptionKeyCache.GetOrCreate(encryptedColumnEncryptionKey, createItem);