-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-user key store provider registration support #1056
Merged
cheenamalhotra
merged 49 commits into
dotnet:main
from
johnnypham:multitenant-provider-command
May 17, 2021
Merged
Add multi-user key store provider registration support #1056
cheenamalhotra
merged 49 commits into
dotnet:main
from
johnnypham:multitenant-provider-command
May 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnypham
added
the
🆕 Public API
Issues/PRs that introduce new APIs to the driver.
label
Apr 28, 2021
cheenamalhotra
requested review from
DavoudEshtehari,
JRahnama and
cheenamalhotra
April 30, 2021 21:07
JRahnama
reviewed
May 3, 2021
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/LocalCache.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
May 8, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSymmetricKeyCache.cs
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
May 8, 2021
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
…ecurityUtility.cs Co-authored-by: David Engel <dengel1012@gmail.com>
…ecurityUtility.cs Co-authored-by: David Engel <dengel1012@gmail.com>
…ecurityUtility.cs Co-authored-by: David Engel <dengel1012@gmail.com>
…ecurityUtility.cs Co-authored-by: David Engel <dengel1012@gmail.com>
JRahnama
reviewed
May 12, 2021
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/LocalCache.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/LocalCache.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/LocalCache.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/LocalCache.cs
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
…t/SqlConnection.cs Co-authored-by: Javad <v-jarahn@microsoft.com>
…nnypham/SqlClient into multitenant-provider-command
JRahnama
reviewed
May 13, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSymmetricKeyCache.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you assess TTL by adding more tests?
doc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionKeyStoreProvider.xml
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/AKVUnitTests.cs
Outdated
Show resolved
Hide resolved
...oft.Data.SqlClient/add-ons/AzureKeyVaultProvider/SqlColumnEncryptionAzureKeyVaultProvider.cs
Show resolved
Hide resolved
…/AKVUnitTests.cs Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
…/AKVUnitTests.cs Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
…/AKVUnitTests.cs Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
…/AKVUnitTests.cs Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
…oreProvider.xml Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
…/AKVUnitTests.cs Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
cheenamalhotra
approved these changes
May 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM 👍
.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj
Show resolved
Hide resolved
JRahnama
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a public method to register providers into an instance cache at the command-level, allowing users to maintain their own set of providers in the same application.
The current column encryption key (CEK) cache is global so a new CEK cache and signature verification cache is added at the
SqlColumnEncryptionAzureKeyVaultProvider
level. EachSqlColumnEncryptionAzureKeyVaultProvider
is linked to a singleTokenCredential
, which serves as the user identity.